Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ESLint in pre-commit and on Travis CI #624

Merged
merged 5 commits into from
Mar 14, 2018
Merged

Enable ESLint in pre-commit and on Travis CI #624

merged 5 commits into from
Mar 14, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Mar 14, 2018

Description

The goal of this PR is to enable eslint to run via pre-commit and on Travis, to ensure JS styling on already styled files.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

pre-commit, travis, git

Testing
  • Tested the pre-commit with both failing and passing cases
  • Tested Travis on mbeacom/web

@mbeacom mbeacom added frontend This needs frontend expertise. needs review labels Mar 14, 2018
@mbeacom mbeacom self-assigned this Mar 14, 2018
@mbeacom mbeacom requested a review from owocki March 14, 2018 16:41
@owocki
Copy link
Contributor

owocki commented Mar 14, 2018

lgtm

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   33.97%   33.97%           
=======================================
  Files          92       92           
  Lines        5053     5053           
  Branches      584      584           
=======================================
  Hits         1717     1717           
  Misses       3269     3269           
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d7ffa...b9e960f. Read the comment docs.

@mbeacom mbeacom merged commit ddfbb0c into gitcoinco:master Mar 14, 2018
@mbeacom mbeacom deleted the travis-eslint branch March 14, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants