Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontawesome: upgrade to v5 #635

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Mar 16, 2018

Description
  • Update font-awesome library to 5!
  • Removed the old library and replaced it with the new one
  • Followed the upgrade instructions as mentioned in the docs
  • Updated the icons + css across the site
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Refers/Fixes

#593

@thelostone-mc
Copy link
Member Author

@mkosowsk mind helping me with the review?

@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #635   +/-   ##
======================================
  Coverage    34.8%   34.8%           
======================================
  Files          90      90           
  Lines        5014    5014           
  Branches      572     572           
======================================
  Hits         1745    1745           
  Misses       3203    3203           
  Partials       66      66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f696fbb...a954663. Read the comment docs.

@mkosowsk
Copy link

@thelostone-mc sure will take a peak

@mkosowsk
Copy link

Code LGTM but did not test :D This PR has earned the 💪🏻🤠👍🏻Mitch Kosowski Seal of Approval™

For other reviewers, @thelostone-mc linked the docs but here is the relevant section on why there are a lot of icon name changes in this update upgrade:

screen shot 2018-03-17 at 7 39 47 am

@thelostone-mc
Copy link
Member Author

@mbeacom looks good from our end !!

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I'll test this following the inline validation PRs and get it merged if 👌

@mbeacom mbeacom added upgrade frontend This needs frontend expertise. labels Mar 19, 2018
@thelostone-mc
Copy link
Member Author

@mbeacom rebased ^_^

@mbeacom mbeacom merged commit 295efd9 into gitcoinco:master Mar 21, 2018
@thelostone-mc thelostone-mc deleted the font-awesome branch April 3, 2018 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants