-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fontawesome: upgrade to v5 #635
Conversation
6050c8b
to
4c40656
Compare
@mkosowsk mind helping me with the review? |
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
======================================
Coverage 34.8% 34.8%
======================================
Files 90 90
Lines 5014 5014
Branches 572 572
======================================
Hits 1745 1745
Misses 3203 3203
Partials 66 66 Continue to review full report at Codecov.
|
@thelostone-mc sure will take a peak |
Code LGTM but did not test :D This PR has earned the 💪🏻🤠👍🏻Mitch Kosowski Seal of Approval™ For other reviewers, @thelostone-mc linked the docs but here is the relevant section on why there are a lot of icon name changes in this update upgrade: |
@mbeacom looks good from our end !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I'll test this following the inline validation PRs and get it merged if 👌
4c40656
to
a954663
Compare
@mbeacom rebased ^_^ |
Description
Checklist
Affected core subsystem(s)
Refers/Fixes
#593