Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offchain Bounties #673

Merged
merged 14 commits into from
Mar 21, 2018
Merged

Offchain Bounties #673

merged 14 commits into from
Mar 21, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Mar 21, 2018

Description

Implements external bounties per #447

Still TODO:

  • Design cleanup
  • Responsive design fixes

After launch:

  • Seed the market with initial external bounties and do a little testing
  • then - only when ready -- Listing on /tools page
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

ui
bounties

Refers/Fixes

#447

@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #673 into master will increase coverage by 0.08%.
The diff coverage is 49.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   34.63%   34.72%   +0.08%     
==========================================
  Files          90       96       +6     
  Lines        5047     5305     +258     
  Branches      575      605      +30     
==========================================
+ Hits         1748     1842      +94     
- Misses       3232     3387     +155     
- Partials       67       76       +9
Impacted Files Coverage Δ
app/app/settings.py 88.4% <ø> (+0.9%) ⬆️
app/external_bounties/apps.py 0% <0%> (ø)
app/app/urls.py 100% <100%> (ø) ⬆️
app/external_bounties/forms.py 100% <100%> (ø)
app/external_bounties/admin.py 100% <100%> (ø)
app/external_bounties/router.py 100% <100%> (ø)
app/marketing/mails.py 13.6% <16.66%> (+0.11%) ⬆️
app/external_bounties/views.py 18% <18%> (ø)
app/external_bounties/models.py 55.31% <55.31%> (ø)
app/app/sitemaps.py 72.5% <70%> (-0.84%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e8f6d...784d81b. Read the comment docs.

@owocki owocki changed the title WIP - Offchain Bounties Offchain Bounties Mar 21, 2018
@mbeacom mbeacom self-requested a review March 21, 2018 16:19
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few adjustments, but lgtm 👍

@@ -30,6 +31,10 @@ def items(self):
'whitepaper_access',
'_leaderboard',
'ios',
'faucet',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@owocki owocki merged commit 533260d into master Mar 21, 2018
@mbeacom mbeacom deleted the kevin/offchain_bounties branch March 21, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants