-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: https://github.com/gitcoinco/web/issues/642 #728
Conversation
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 33.79% 33.96% +0.17%
==========================================
Files 101 101
Lines 5750 5765 +15
Branches 671 671
==========================================
+ Hits 1943 1958 +15
Misses 3728 3728
Partials 79 79
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew!
@bakaoh Thank you for the contribution! Overall, the changes lgtm. I'm going to deploy this to staging at: https://stage.gitcoin.co following some local testing.
I'll ping back and approve the PR following QA.
Thanks again!
app/dashboard/models.py
Outdated
@@ -29,6 +29,7 @@ | |||
from django.db.models.signals import m2m_changed, post_delete, post_save, pre_save | |||
from django.dispatch import receiver | |||
from django.utils import timezone | |||
from django.utils.translation import gettext_lazy as _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
dat plus minus! strong effort @bakaoh ! @bakaoh could you talk a little bit about how you traversed the codebase to get this done? how can we be assured that you didnt miss anything from the initial scope? looks like this still needs to be done:
(the subject lines need to be done.. looks like the templates are done) @mbeacom we should put this on the fast track to merge so that we dont end up with endless merge conflicts! |
@mbeacom i resolved the conflicts and commit the
i'd just gone through each file line by line, it took more time than expected but it gave me a change to know more about the codebase, i even found a minor bug at file |
very excited to ship this soon. this unlocks translation which could be really huge for gitcoin in the future |
@mbeacom any update here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - Conflicts resolved.
just tagged the current master with |
Description
Enable Internationalization in the app
Checklist
Affected core subsystem(s)
No
Testing
Just add some simple code to enable internationalization. Nothing involves logic or business code.
Refers/Fixes
Fixes: #642