Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty: css fix for wonky contributor info #741

Merged
merged 3 commits into from
Mar 29, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Mar 29, 2018

Description
  • Fixed wonky contributor info
  • Added comma separated info
Issue

screen shot 2018-03-28 at 9 34 54 pm

Fix

Fixed wonky contributor info

screen shot 2018-03-29 at 12 55 06 pm

Updates:

Added comma separated info

screen shot 2018-03-29 at 7 50 15 pm

screen shot 2018-03-29 at 8 05 39 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css
  • js

@PixelantDesign

@mbeacom mbeacom added frontend This needs frontend expertise. needs design labels Mar 29, 2018
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending review by design

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #741 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #741   +/-   ##
======================================
  Coverage    34.4%   34.4%           
======================================
  Files         101     101           
  Lines        5610    5610           
  Branches      647     647           
======================================
  Hits         1930    1930           
  Misses       3606    3606           
  Partials       74      74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0919f6d...70914be. Read the comment docs.

@mbeacom
Copy link
Contributor

mbeacom commented Mar 29, 2018

Can you resolve the conflicts here? @thelostone-mc
sorry1

@mbeacom
Copy link
Contributor

mbeacom commented Mar 29, 2018

@PixelantDesign Are you good with the changes reflected in the attached screenshots?

@thelostone-mc
Copy link
Member Author

Reduced the spacing between names as it look better (discussed offline with @PixelantDesign )

screen shot 2018-03-30 at 1 34 09 am

@mbeacom conflicts resolved! we are good to go and fixed up profileHtml function which are newly added!

Also which variable naming style are we sticking to ? camelCase / under_score / hyp-hen ? :P

@mbeacom mbeacom merged commit 2ccd03a into gitcoinco:master Mar 29, 2018
@thelostone-mc thelostone-mc deleted the fix branch April 3, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants