-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bounty: added progress bar #764
Conversation
@PixelantDesign As promised ^_^ (Used green instead of blue, we can change it back to blue -> if you want that ) |
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 34.33% 34.33%
=======================================
Files 99 99
Lines 5767 5767
Branches 674 674
=======================================
Hits 1980 1980
Misses 3702 3702
Partials 85 85 Continue to review full report at Codecov.
|
|
||
if (new Date(val) < new Date()) { | ||
var percent = 100 * ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please forgive the nitpick, but would something like percentCompleted be a bit more explicit? 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did I that miss 😅
percentCompleted
or something better ? 🤔
It signifies the time left % , help me out here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️ No judgement here!
Raised a super minor naming nitpick but this LGTM 👍🏻 Didn't test tho |
@@ -165,11 +165,11 @@ var callbacks = { | |||
expires_date = new Date(val); | |||
now = new Date(result['now']); | |||
|
|||
var percent = 100 * ( | |||
var expiringInPercentage = 100 * ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨⚖️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm - @PixelantDesign Are you good with this?
@thelostone-mc Would you mind resolving the |
@mbeacom Done! |
Taken care of! |
@mbeacom conflicts resolved |
Description
Checklist
Affected core subsystem(s)