-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit Profile stat results to valid bounties #791
Conversation
@owocki I've updated the proposed changes to use |
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 33.79% 33.85% +0.06%
==========================================
Files 101 101
Lines 5750 5757 +7
Branches 671 672 +1
==========================================
+ Hits 1943 1949 +6
- Misses 3728 3729 +1
Partials 79 79
Continue to review full report at Codecov.
|
Code LGTM tho didn't test 👍🏻 thanks @mbeacom, this will be a nice fix so we don't harm stats for contributors for stuff that's outside of their control :) |
okie dokie.. its a little less than elegant, but its still a step forward. makes sense to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shippit
@owocki What would your ideal implementation be? If you'd prefer, I can refactor the way we're determining the status, rename the field throughout, and modify the signaling. I just figured less changes in this PR was ideal. I am fine with making the changes in this branch, though. |
prettymuch what you describe below, though i agree with your judgement call to not bother in retrospect.
i say lets shippit once tested |
Description
The goal of this PR is to allow filtering of bounties by a status field versus a property. This allows us to filter out
unknown
orcancelled
bounties from the profile stats.This PR introduces the
Bounty.status
field, renamingBounty.status
property toBounty.current_status
, migrates existing statuses, adds thestats_eligible
queryset function, and makes use of it inProfile.stats
.Checklist
Testing
Tested locally and on staging.
You can observe the state of these changes on: https://stage.gitcoin.co/profile/bradford-hamilton and compare against: https://gitcoin.co/profile/bradford-hamilton