-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bounty: unify modal designs #809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks sane. 👍 Going to pull this down and test locally.
@sethmcleod Is there anything I can do to assist you in getting this across the finish line? |
@sethmcleod You mean just this bit is left ? Whatever you've updated till now -> it's completed / mergeable right ? |
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
- Coverage 32.08% 32.04% -0.05%
==========================================
Files 105 105
Lines 7237 7237
Branches 940 940
==========================================
- Hits 2322 2319 -3
- Misses 4807 4810 +3
Partials 108 108
Continue to review full report at Codecov.
|
That's correct @thelostone-mc, all other changes have just been based on design feedback from Alisa. This is now safe to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks okay to me. Going to test this and merge, unless there are objections. @thelostone-mc @SaptakS ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -30,11 +30,11 @@ | |||
$palette: ( | |||
bg: #ffffff, | |||
bg-alt: #e1dfe8, | |||
fg: #414f57, | |||
fg: #000000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
Description
WIP
This will resolve #430
Checklist
Affected core subsystem(s)
UI, maybe Dashboard? Not 100% sure how to answer this 😅
Testing
Refers/Fixes
Fixes: #430