Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bounty: unify modal designs #809

Merged
merged 5 commits into from
May 3, 2018
Merged

bounty: unify modal designs #809

merged 5 commits into from
May 3, 2018

Conversation

sethmcleod
Copy link
Contributor

@sethmcleod sethmcleod commented Apr 5, 2018 •
edited
Loading

Description

WIP

This will resolve #430

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

UI, maybe Dashboard? Not 100% sure how to answer this 😅

Testing
Refers/Fixes

Fixes: #430

@sethmcleod sethmcleod mentioned this pull request Apr 5, 2018
Closed
mbeacom
mbeacom reviewed Apr 9, 2018
View reviewed changes
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane. 👍 Going to pull this down and test locally.

@mbeacom mbeacom added enhancement This is a feature to be enhanced or improved. needs-testing frontend This needs frontend expertise. labels Apr 9, 2018
@sethmcleod
Copy link
Contributor Author

Thanks @mbeacom! This is still a WIP at the moment; will be ready as soon as I finish implementing the new Get Started modal based on this feedback.

@mbeacom mbeacom changed the title bounty: unify modal designs (WIP) bounty: unify modal designs Apr 9, 2018
@mbeacom
Copy link
Contributor

mbeacom commented Apr 30, 2018

@sethmcleod Is there anything I can do to assist you in getting this across the finish line?

@sethmcleod
Copy link
Contributor Author

Hey @mbeacom. Unfortunately I won't be able to wrap this one up; would you or anyone else be able to take over? Based on #430, I believe all that's left is to setup a new /get-started page that uses yge assets similar to /tip so we can give it the same background/feel.

@thelostone-mc
Copy link
Member

@sethmcleod You mean just this bit is left ?

Whatever you've updated till now -> it's completed / mergeable right ?
If not we could get it to a mergeable state + resolve conflicts -> I'll pick it up

@codecov
Copy link

codecov bot commented May 1, 2018 •
edited
Loading

Codecov Report

Merging #809 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
- Coverage   32.08%   32.04%   -0.05%     
==========================================
  Files         105      105              
  Lines        7237     7237              
  Branches      940      940              
==========================================
- Hits         2322     2319       -3     
- Misses       4807     4810       +3     
  Partials      108      108
Impacted Files Coverage Δ
app/app/settings.py 80.79% <0%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38533af...1c970bb. Read the comment docs.

@sethmcleod
Copy link
Contributor Author

That's correct @thelostone-mc, all other changes have just been based on design feedback from Alisa. This is now safe to merge.

@mbeacom mbeacom added needs-testing and removed wip labels May 1, 2018
@mbeacom mbeacom changed the title (WIP) bounty: unify modal designs bounty: unify modal designs May 1, 2018
mbeacom
mbeacom approved these changes May 1, 2018
View reviewed changes
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay to me. Going to test this and merge, unless there are objections. @thelostone-mc @SaptakS ?

SaptakS
SaptakS approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mbeacom
mbeacom approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

app/assets/yge/sass/libs/_vars.scss
@@ -30,11 +30,11 @@
$palette: (
bg: #ffffff,
bg-alt: #e1dfe8,
fg: #414f57,
fg: #000000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@mbeacom mbeacom merged commit f45d40f into gitcoinco:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@mbeacom mbeacom mbeacom approved these changes

@SaptakS SaptakS SaptakS approved these changes

Assignees
No one assigned
Labels
enhancement This is a feature to be enhanced or improved. frontend This needs frontend expertise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify Modal Designs
4 participants
@sethmcleod @mbeacom @thelostone-mc @SaptakS