Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipdb and django shell access to docker setup #863

Merged
merged 2 commits into from
Apr 11, 2018
Merged

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Apr 11, 2018

Description

The goal of this PR is to introduce entrypoints for ipdb and the django shell via make commands.
The method used in this PR allows us to inspect the ipdb shell and the django shells without an additional container in our compose stack.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Testing

Tested with multiple web repo directories to ensure the parent directory name (first part of compose image name) is properly detected.

Refers/Fixes

Ref #861 - This PR aims to handle the same case as this PR.

@mbeacom mbeacom added docker backend This needs backend expertise. documentation labels Apr 11, 2018
@mbeacom mbeacom changed the title Add make commands for accessing ipdb and django shells Add ipdb and django shell access to docker setup Apr 11, 2018
@mbeacom mbeacom mentioned this pull request Apr 11, 2018
@owocki
Copy link
Contributor

owocki commented Apr 11, 2018

very excited about this :)

@codecov
Copy link

codecov bot commented Apr 11, 2018

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   33.86%   33.86%           
=======================================
  Files         101      101           
  Lines        5797     5797           
  Branches      679      679           
=======================================
  Hits         1963     1963           
  Misses       3754     3754           
  Partials       80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12afc0...cc94505. Read the comment docs.

@mbeacom mbeacom merged commit 2fec975 into master Apr 11, 2018
@mbeacom mbeacom deleted the mark-docker-ipdb branch April 11, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise. docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants