WIP: Update FaucetRequest with FK to Profile #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeacom
commented
Apr 13, 2018
app/faucet/views.py
Outdated
| @@ -90,12 +92,12 @@ def save_faucet(request): | |||
| }, status=400) | |||
| fr = FaucetRequest.objects.create( | |||
| fulfilled=False, | |||
| github_username=github_profile, | |||
| input_github_username=profile_handle, | |||
| github_username=request.user.username, | |||
| github_meta=checkeduser, | |||
There was a problem hiding this comment.
@owocki Do we need or want the GH payload here? We could eliminate the additional call to GH entirely if we don't need github_meta/checkeduser
mbeacom
changed the title
Codecov Report
@@ Coverage Diff @@
## master #884 +/- ##
==========================================
+ Coverage 31.48% 31.56% +0.08%
==========================================
Files 106 106
Lines 7214 7227 +13
Branches 939 939
==========================================
+ Hits 2271 2281 +10
- Misses 4833 4836 +3
Partials 110 110
Continue to review full report at Codecov.
|
owocki
approved these changes
Apr 13, 2018
app/faucet/views.py
Outdated
| @@ -90,12 +92,12 @@ def save_faucet(request): | |||
| }, status=400) | |||
| fr = FaucetRequest.objects.create( | |||
| fulfilled=False, | |||
| github_username=github_profile, | |||
| input_github_username=profile_handle, | |||
| github_username=request.user.username, | |||
There was a problem hiding this comment.
does this need to be wrapped around request.user.is_authenticated() ?
There was a problem hiding this comment.
Not in this case. We're validating that profile is present on L67 which relies on L65 that checks if request.user.is_authenticated, otherwise the user will receive a 401.
stickler-ci
reviewed
Apr 18, 2018
| migrations.AddField( | ||
| model_name='faucetrequest', | ||
| name='profile', | ||
| field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='faucet_requests', to='dashboard.Profile'), |
There was a problem hiding this comment.
E501 line too long (149 > 120 characters)
CuriousLearner
added a commit
to CuriousLearner/web
that referenced
this pull request
May 1, 2018
…6-296 * 'master' of https://github.com/gitcoinco/web: (31 commits) fixes https://rollbar.com/gitcoin/gitcoin/items/908 dashboard.js -- onboard search was expecing falsy value, not -1 measure hourly rates of different repos Fix url collision Restrict onboarding view to staff temporarily sets default search project status to 'any' (gitcoinco#936) staggers cron start times (gitcoinco#1034) dont show email address if not auth fixes gitcoinco#1025 obfuscate usernames review: added feedback review: added feedback onboard: refactored code dashboard: handle redirect from onboard ftux: birth WIP: Update FaucetRequest with FK to Profile (gitcoinco#884) fixes tests no more underscore methods for non-private methods Fix gitcoinco#1032 - Resolve trans rendering for faucet request copy allow user to skip waiting for tip tx to clear blockchain ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to deprecate some of the old user handling in the Faucet related views and add a FK relation between
FaucetRequestandProfile.Checklist
Affected core subsystem(s)
faucet, profile