Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to add a pr link to work submission #900

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Apr 16, 2018

Description

ability to add a pr link to work submission. useful to have for if we ever want to reference that PR directly for any reason

screen shot 2018-04-16 at 12 53 41 pm

screen shot 2018-04-16 at 12 53 35 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

ui, bounty, etc

Testing

tested it

Refers/Fixes

self

@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #900 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   33.51%   33.52%   +0.01%     
==========================================
  Files          99       99              
  Lines        6117     6118       +1     
  Branches      735      735              
==========================================
+ Hits         2050     2051       +1     
  Misses       3972     3972              
  Partials       95       95
Impacted Files Coverage Δ
app/dashboard/router.py 38.15% <ø> (ø) ⬆️
app/dashboard/helpers.py 29.09% <ø> (ø) ⬆️
app/dashboard/models.py 64.45% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2caa03c...b9ddd0b. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom added the frontend This needs frontend expertise. label Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants