Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about: core team design revamp #916

Merged
merged 4 commits into from
Apr 20, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 18, 2018

Description
  • Cleaned up the team section in /about
  • Added missing div
  • Pending removal of stale CSS code once I can get the mgmt commands working to populate the leaderboard
  • Updated job opening section

screen shot 2018-04-18 at 5 31 49 pm

screen shot 2018-04-18 at 11 15 09 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • html
  • css

team_members_left = [
(static("v2/images/team/kevin-owocki.png"), "Kevin Owocki", "All teh things", "owocki", "The Community", "Avocado Toast"),
core_team = [
(static("v2/images/team/kevin-owocki.png"), "Kevin Owocki", "All the things", "owocki", "The Community", "Avocado Toast"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (130 > 120 characters)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stickler-ci :P

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #916 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   33.47%   33.43%   -0.05%     
==========================================
  Files          99       99              
  Lines        6150     6150              
  Branches      740      740              
==========================================
- Hits         2059     2056       -3     
- Misses       3996     3999       +3     
  Partials       95       95
Impacted Files Coverage Δ
app/retail/views.py 39.84% <0%> (+0.3%) ⬆️
app/app/settings.py 80.27% <0%> (-2.05%) ⬇️
app/retail/emails.py 23.62% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f4b6f...33c5bb4. Read the comment docs.

@thelostone-mc
Copy link
Member Author

Pending: LinkedIn Profile of the core team so that I can link those up!

@gitcoinco gitcoinco deleted a comment from gitcoinbot Apr 18, 2018
@owocki
Copy link
Contributor

owocki commented Apr 18, 2018

pls ignore the aboev ^ it was me testing

@owocki
Copy link
Contributor

owocki commented Apr 18, 2018

my linkedin profile => linkedin.com/in/owocki/

@owocki
Copy link
Contributor

owocki commented Apr 18, 2018

you can get others' on slack if u want

@thelostone-mc
Copy link
Member Author

@owocki Yup got it ! @mbeacom was nice enough to gimme the links ^_^

Oh PS: Got the rotate + scale + change color effect you wanted 😂
It looks neat

@thelostone-mc
Copy link
Member Author

@mbeacom @PixelantDesign this look alright ?

@PixelantDesign
Copy link
Contributor

Nice!

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit 78d7478 into gitcoinco:master Apr 20, 2018
@gitcoinco gitcoinco deleted a comment from darkdarkdragon Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants