-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autotranslate base #971
Conversation
can we source someone who is german to tell us how good/bad the autotranslate is? if not german, maybe another language? vivek might be able to help us with sourcing this person |
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 28.57% 28.57% -0.01%
==========================================
Files 128 128
Lines 10070 10067 -3
Branches 1328 1327 -1
==========================================
- Hits 2878 2877 -1
+ Misses 7091 7089 -2
Partials 101 101
Continue to review full report at Codecov.
|
@owocki This PR should be good to merge - Test the latest at: https://stage.gitcoin.co -> Settings -> Preferred Language - Temporarily disabled zh (Chinese) and po (Polish). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the concerns noted in slack are addresssed
@mbeacom go for it
How come ? |
@PixelantDesign @mbeacom Do we want to auto-translate visitors based upon IP addresses? |
oh also, it might be worth testing the emails @mbeacom |
@owocki We can serve the appropriate language based on their Also, testing emails now! |
i think the
got it. we should figure out the CDN issue before going live, since the prod site is on the CDN |
@mbeacom this is a prioroity for decentralland -- any way we can prioritize shipping it? |
@mbeacom what was the issue with chinese translation and is it fixed on this PR? |
@owocki It was my mistake. I specified |
Description
The goal of this PR is to add
autotranslate
and introduceGerman
locale.Adds:
autotranslate
django appmake autotranslate
command for automatically translating/updating existing translationsLangauge support for:
TODO:
Add mechanism to automatically replace poorly parsed special characters for python dynamic vars.
Example:
should be:
Checklist
Affected core subsystem(s)
i18n
Testing
Tested locally
Refers/Fixes
Ref #814