Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error displaying differences #309

Closed
sanctus17 opened this issue May 1, 2017 · 5 comments
Closed

Error displaying differences #309

sanctus17 opened this issue May 1, 2017 · 5 comments

Comments

@sanctus17
Copy link

Description

There seems to be a bug when comparing different versions of a page, p.e. current version with an old revision. The edited text doesn't display because text and background have the same color (red or green).

Steps to Reproduce

  1. Open a dokuwiki page
  2. click on 'old revisions'
  3. select two versions and click 'show differences between selected revisions'

Expected behavior: Changes can be compared side to side.

Actual behavior: Only green / red blocks appear, the text seems to be hidden inside the same colored boxes. Manual selection if the text will reveal it by temporarily adjusting the background color (see attached screenshots).

Versions

  • latest Bootstrap3 template
  • Dokuwiki Release 2017-02-19b "Frusterick Manners"
  • Safari but same happens in Chrome and Firefox

Screenshots or Logs

scrshot01

scrshot02

Thank you!

@phy25
Copy link
Contributor

phy25 commented May 1, 2017

What Bootswatch varient are you using?

I have found before, that in some Bootswatch version, colors of .text-** and .bg-** are the same, causing this issue.

@sanctus17
Copy link
Author

Thank you for your comment.

It is the Lumen theme and Bootswatch.com Design.
Indeed, when switching to Vanilla Bootstrap Design, the issue resolves. That is a total different theme, though.

@CvH
Copy link

CvH commented May 2, 2017

this is fixed with #265

@giterlizzi
Copy link
Owner

The PR #265 is merged into code! Thanks!

@giterlizzi giterlizzi added this to the v2017-09 milestone Sep 22, 2017
giterlizzi added a commit that referenced this issue Sep 22, 2017
@ariasuni
Copy link

It’s still too hard to read black on red or green with Lumen theme, it should use white like on Cards on Lumen page. I’m not sure how and where to fix this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants