Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with plugin:ToDo #354

Closed
nurzu opened this issue Feb 27, 2018 · 2 comments
Closed

Conflict with plugin:ToDo #354

nurzu opened this issue Feb 27, 2018 · 2 comments

Comments

@nurzu
Copy link

nurzu commented Feb 27, 2018

Description

Since I upgraded Bootstrap3 to its new version, the Plugin ToDo doesn't show the checkbox as checked anymore, but left unchecked as seen on the screenshot. Maybe the class is overwritten. It was working fine in v2016-12-12.

Steps to reproduce

  1. Creating a task/checkbox in the editor
  2. Marking it as „done“ by adding a # to the tag
  3. Saving the article

or

  1. Marking it as „done“ by clicking it > marked as done
  2. Reloading page > marked as undone

Expected "visual" behavior: Checkbox is marked as checked (blue)

Actual "visual" behavior: Checkbox remains empty, unchecked (blank)

Versions

  • [Bootstrap3 Template] v2018-02-16
  • [DokuWiki] Release 2017-02-19e “Frusterick Manners”
  • [Plugins] ToDo Last updated on 2017-01-06
  • [Browser] All modern browsers

Screenshots or Logs

todo

Thanks

Bootstrap3 Template is just great. Thank you so much for creating it!

@giterlizzi
Copy link
Owner

Hi @nurzu,
thanks for reporting this issue,

I have applied workaround in master and develop branch and have opened a PR (merged just few minutes ago) with the fix on Todo Plugin repository.

You can reinstall the template again ?

At your disposal,
Joseph

@nurzu
Copy link
Author

nurzu commented Feb 28, 2018

I reinstalled the template and tested it afterwards on all modern browsers. All works quite well!
Just brilliant. Thanks!

@nurzu nurzu closed this as completed Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants