Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation plugin broken in bootstrap3 #389

Closed
tmo26 opened this issue Aug 12, 2018 · 7 comments
Closed

translation plugin broken in bootstrap3 #389

tmo26 opened this issue Aug 12, 2018 · 7 comments

Comments

@tmo26
Copy link

tmo26 commented Aug 12, 2018

Description

The translation plugin is broken in bootstrap3:

  • Flags are repeated instead of being shown only once, making language text unreadable
  • No action at all when clicking on a language in the pulldown menu

Steps to reproduce

  1. Install bootstrap3
  2. Install translation plugin
  3. configure translation plugin: show langcode, flags, names
  4. Go to an arbitrary wiki page and click on the translation dropdown

Expected behavior:

  • One flag should be shown as in screenshot below
  • When clicking on a language in the translation dropdown, the page should be switched to the selected language page

Actual behavior:

  • Flags are repeated instead of being shown only once, making language text unreadable.
  • No action at all when clicking on a language in the pulldown menu, making it impossible to switch to another language via the translation dropdown.

Versions

  • [Bootstrap3 Template] 2018-02-16
  • [DokuWiki] 2018-04-22a "Greebo"
  • [Translation Plugin] 2018-08-07
  • [Browser] FF 61.0.2 + Chrome 68.0.3440.106

Screenshots or Logs

Translation plugin working as expected with custom template:
grafik

Translation plugin not working as expected with bootstrap3 template:
grafik

@giterlizzi
Copy link
Owner

Hi @tmo26, i have replicated your configuration in testing environment and the plugin work correctly.

You can force update the plugin and the template, and try again ?

At your disposal,
Joseph

@tmo26
Copy link
Author

tmo26 commented Oct 27, 2018

After update of bootstrap3 template and re-installation of the translate plugin: No change, same as before.

@Str3amR
Copy link

Str3amR commented Jul 23, 2019

I just hit the same problem today after upgrading to latest version of both plugins, we had to change this line to 0:
$conf['plugin']['translation']['dropdown'] = 1;

The dropdown is still there and everything seems to be displayed correctly afterwards.

@tmo26
Copy link
Author

tmo26 commented Jul 23, 2019

In which file do I find this line?

Edit 1: OK, found it in the wiki configuration.
Confirmed, unchecking plugin»translation»dropdown makes the translation dropdown being shown correctly.
image

Edit 2: checking/unchecking plugin»translation»dropdown makes either our custom template work OR the bootstrap3 template, but not both.

How the custom template looks now with this option unchecked:
image

Expected behaviour: checking plugin»translation»dropdown should behave the same in all templates, in order to enable users to switch between templates via loadskin plugin without a change in the UI logic (dropdown or not).

@Str3amR
Copy link

Str3amR commented Jul 23, 2019

Yes you're right, the workaround worked for us because we only use one template, but it's still a bug.

@tmo26
Copy link
Author

tmo26 commented Oct 18, 2019

Update

Issue is still present with the following:

  • [Bootstrap3 Template] 2019-05-22
  • [DokuWiki] 2018-04-22b "Greebo"
  • [Translation Plugin] 2018-08-07
  • [Browser] FF 69.0.3 + Chrome 77.0.3865.120

@giterlizzi Do you have an outlook when this issue could be fixed?

giterlizzi added a commit that referenced this issue Feb 5, 2020
@giterlizzi
Copy link
Owner

Finally fixed! :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants