Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables not styled correctly #405

Closed
weibell opened this issue Feb 17, 2019 · 7 comments
Closed

Tables not styled correctly #405

weibell opened this issue Feb 17, 2019 · 7 comments
Labels
Milestone

Comments

@weibell
Copy link

weibell commented Feb 17, 2019

Description

It appears that tables aren't styled correctly (or rather: at all) in DokuWiki 2018-04-22b "Greebo".

Steps to reproduce

  1. Install stable DokuWiki
  2. Add and select Bootstrap3 Template, leave all settings on default
  3. Create new page with table or simply visit "wiki:syntax"
  4. Observe that tables are not styled at all (e.g. no 100% width, no stripes, etc.)

Expected behavior:

Something like this:

image

Actual behavior:

image

Versions

  • [Bootstrap3 Template] v2018-02-16
  • [DokuWiki] 2018-04-22b "Greebo"
  • [Plugins] none
  • [Browser] Firefox, Chromium, Edge, ...
@phy25
Copy link
Contributor

phy25 commented Feb 17, 2019

I guess table style of Bootstrap will be applied if you use tableFullWidth and tableStyle in template config.

@weibell
Copy link
Author

weibell commented Feb 17, 2019

Those options are already enabled by default:

image

@phy25
Copy link
Contributor

phy25 commented Feb 17, 2019

I guess code here is not working as expected. If you like you may want to check if any classes have been rewritten to the table:

https://github.com/LotarProject/dokuwiki-template-bootstrap3/blob/119aa216fa8a48d49a1af7c24aa4045ab9f18ed1/tpl_functions.php#L2002-L2029

@weibell
Copy link
Author

weibell commented Feb 17, 2019

I figured it out. In the PHP 7 environment, the output was
<div class="table sectionedit22"><table class="inline"> ...

After I switched to PHP 5.6, it now correctly outputs:
<div class="table-responsive"><table class="inline table table-striped table-condensed"> ...

@weibell
Copy link
Author

weibell commented Feb 18, 2019

Upon closer inspection, the issue appears to have been with the "PHP Simple HTML DOM Parser" dependency (#404), which is incompatible with PHP 7.

@weibell weibell closed this as completed Feb 18, 2019
giterlizzi added a commit that referenced this issue Feb 22, 2019
@giterlizzi
Copy link
Owner

Hi,
I have fixed this issue in develop branch using this patch #400.

@giterlizzi giterlizzi added the bug label Feb 22, 2019
@giterlizzi giterlizzi added this to the v2019-04 milestone Mar 12, 2019
@ParoTheParrot
Copy link

hoho - waiting for the next release with correct table layout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants