Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The footer is not sticky #415

Closed
lifehome opened this issue Apr 24, 2019 · 5 comments
Closed

The footer is not sticky #415

lifehome opened this issue Apr 24, 2019 · 5 comments

Comments

@lifehome
Copy link

lifehome commented Apr 24, 2019

Description

The footer is not sticky.

Steps to reproduce

  1. Install Dokuwiki
  2. Install and activate Bootstrap 3 template
  3. Go to a new empty page, and see the not so sticky footer.

Expected behavior:
I expect it to stick.

Actual behavior:
It doesn't.

Versions

  • [Bootstrap3 Template] 2018-02-16
  • [DokuWiki] 2018-04-22b "Greebo"
  • [Plugins]
  • [Browser]

Screenshots or Logs


image


Sample page or snippet

https://wiki.toughlife.info/hahaha

@giterlizzi
Copy link
Owner

Hi @lifehome,
Thanks for reporting this issue.

I have corrected this behavior on develop and upcoming version of template.

At your disposal,
Joseph

@lifehome
Copy link
Author

@LotarProject Sorry but it is not fixed, please check it out on:
https://testwiki.toughlife.info/hahaha?purge=true

This subdomain is pulling the develop branch directly from GitHub, so it should be up-to-date with the repo.

@giterlizzi giterlizzi reopened this Apr 25, 2019
giterlizzi added a commit that referenced this issue May 2, 2019
@giterlizzi
Copy link
Owner

Hi @lifehome,
i hope the last commit is the final solution :)

Joseph

@giterlizzi giterlizzi added this to the v2019-04 milestone May 2, 2019
@lifehome
Copy link
Author

lifehome commented May 9, 2019

Hi Joseph,

I have tested it out, and it works great! However, may I ask when will these changes merged into master? We are a bit worried on using the developer branch directly.

Regards,
Ivan

@giterlizzi
Copy link
Owner

I Ivan,

Thanks for your testing.

The changes will be merged into master this or next week (now i'm retesting all template functionalities).

Stay tuned!

Joseph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants