Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between header and footer treatment of logo #440

Closed
leemillerau opened this issue Oct 3, 2019 · 1 comment
Closed

Inconsistency between header and footer treatment of logo #440

leemillerau opened this issue Oct 3, 2019 · 1 comment

Comments

@leemillerau
Copy link

Description

As far as I can tell the logo in the header is displayed using height = 32 and in the footer using width = 32. This leads to interesting results if displaying a user provided logo that is not square.

Steps to reproduce

  1. Upload logo.png where height not = width with Media Manager
  2. Observe different display outcome in header navbar and in footer

Expected behavior: [What you expected to happen]
Header and footer should display in the same way for the same logo file.

Actual behavior: [What actually happened]

Header and footer display logo differently

Versions

  • [Bootstrap3 Template] 2019-05-22
  • [DokuWiki]2018-04-22 "Greebo"
  • [Plugins]
  • [PHP]
  • [Browser]Chrome
    Setting: Bootswatch.com

Screenshots or Logs

[Paste your logs or attach the screenshot]
image

@giterlizzi
Copy link
Owner

Hi @leemillerau,
i have fixed this issue in last commit in development (and upcoming) release.

Joseph

@giterlizzi giterlizzi removed the pending label Dec 6, 2019
@giterlizzi giterlizzi added this to the v2020-01 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants