Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Fontawesome broke Bootswrapper plugin icons #442

Closed
TrapSpace opened this issue Nov 3, 2019 · 5 comments
Closed

Removal of Fontawesome broke Bootswrapper plugin icons #442

TrapSpace opened this issue Nov 3, 2019 · 5 comments
Labels

Comments

@TrapSpace
Copy link

Description

With the removal of Fontawesome in the develop branch, this broke the icons in your Bootswrapper plugin. Since I believe they use Fontawesome form this template.

Steps to reproduce

  1. Install this template from the develop branch
  2. Install Bootswrapper plugin
  3. Add a Callout component with icon=true
  4. You see the Callout component rendered but there is no icon shown

Expected behavior:
See an icon in the Callout component

Actual behavior:
No icon in the Callout component

Versions

  • [Bootstrap3 Template] latest in Develop branch
  • [DokuWiki] Greebo
@giterlizzi
Copy link
Owner

Hi @TrapSpace
I have plan to switch to inline SVG icons or force "Icons" plugin dependency for Bootstrap Wrapper Plugin.

I suggest this workaround,

Joseph

giterlizzi/dokuwiki-plugin-bootswrapper#107

@TrapSpace
Copy link
Author

Hi @giterlizzi

Thanks for your quick reply and the workaround. I look forward to your next updates.

Cheers

@intervisionlord
Copy link

Sad, but this workaround does not work with some elements of wrapper (e.g. buttons).
There is no way to make a button with FA icon and text inside it, because icon placed behind button even if the icon code paced inside button container...

@giterlizzi
Copy link
Owner

In last commit in develop branch, i have re-added the support for FontAwesome4 via Iconify API.

@intervisionlord
Copy link

Thank you for your reply. I'll try to check it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants