Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old toolbar icons since more recent update #503

Closed
FloMiLe opened this issue Aug 11, 2020 · 1 comment
Closed

Old toolbar icons since more recent update #503

FloMiLe opened this issue Aug 11, 2020 · 1 comment

Comments

@FloMiLe
Copy link

FloMiLe commented Aug 11, 2020

Description

I cannot pinpoint which exact update produced this. But with the current bootstrap template version, the editor's toolbar icons have switched back again, away from the more modern looking material icons.

What is weird though, is that the toolbar currently gets loaded in two steps. In the first step, small and slightly gray-ish looking icons appear. Immediately after that slightly bigger and brighter icons are loaded. I could only see this clearly in a screen recording.

Steps to reproduce

  1. Update bootstrap template from a 2019 version to the current 2020 version.

Expected behavior:
The setting ''tpl»bootstrap3»useAlternativeToolbarIcons'' should toggle between old (original) and material icons in the editor's toolbar.

Actual behavior:
This setting has no effect.

Versions

  • Template v2020-07-29 (hotfix/20200804)
  • Release 2020-07-29 "Hogfather"
  • Safari

Screenshots or Logs

If it is unclear which icons I mean, please leave a comment and I will upload screenshots.

@FloMiLe FloMiLe added the bug label Aug 11, 2020
giterlizzi added a commit that referenced this issue Aug 21, 2020
- Fixed very old bug for media manager
- Fixed edit toolbar icons regression for Hogfather release (#503)
- Refactoring JS script
- Added support for upcoming release of Icons plugin with Iconify
- Added confirm dialog for revert action
@giterlizzi giterlizzi added this to the v2020-08 milestone Aug 27, 2020
@FloMiLe
Copy link
Author

FloMiLe commented Aug 29, 2020

Fantastic, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants