Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline:style !important is overwriting userstyle.css/userall.css #517

Closed
nurzu opened this issue Nov 2, 2020 · 0 comments
Closed

inline:style !important is overwriting userstyle.css/userall.css #517

nurzu opened this issue Nov 2, 2020 · 0 comments
Labels
Milestone

Comments

@nurzu
Copy link

nurzu commented Nov 2, 2020

inline:style !important is overwriting userstyle.css/userall.csss

Referring to the changed file: d1ac22c

By adding !important to this class, there is no possibility to overwrite margin-top via userall.css or userstyle.css anymore.
The reason: it's implemented/rendered as in inline:css. All other css files (userall.css or userstyle.css) are imported before that.

Here's the problem: If you have chosen a custom bootstrap theme with a navbar at a different height (e.g. 100px) than all different themes from bootswatch.com, the default setting for the navbar remains 50px as it is defined in template.php. I cannot find a way of overwriting this setting and combination of these variables without editing template.php (which isn't save for updates at all, of course.)

And that is the result: Some content will be hidden behind the navbar, e.g. breadcrumbs, youarehere, social-buttons, print-button or even headlines.


It would be great, if there wouldn't be any classes that include !important, that are rendered by php inline, at all.

Otherwise …

  1. One suggestion to manage "Fixed global margin-top" is to getInfo about .navbar's height without any presets, but by checking the actual height of .navbar while loading the site. This would actually be very helpful if it varies from big device to mobile device.

  2. Another suggestion is to make an input-field in DokuWiki / Bootstrap3 Template / Configuration for a custom presets of .navbar in height. Well, but this might be very complicated.


By the way: I tried these solution, but none of the did the job:

  1. There is the possibility to use padding-top as an addition to margin-top, but it's not a good choice, cause it's effecting scrolling to the anchors via TOC, so that there ain't no precise scrolling anymore.
  2. I tried using this in userall.css
    body.custom .navbar-default {height:100px;}
    but it only effects the navbar and actually does not effect the php-reading/writing for margin-top

Versions

  • Bootstrap3 Template 2020-08-28
    • Custom Design
  • DokuWiki Hogfather 2020-07-29
@nurzu nurzu added the bug label Nov 2, 2020
@nurzu nurzu changed the title inline:style !important is overwriting userstyle.css/userall.csss inline:style !important is overwriting userstyle.css/userall.css Nov 6, 2020
@giterlizzi giterlizzi added this to the v2020-12 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants