Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra check on login page for PHP>=8.0 #577

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

forthommel
Copy link
Contributor

Check case if $_SERVER global variable does not contain the REMOTE_USER key. (spotted when updated php from 7.4 to 8.0)

Check case if `$_SERVER` global variable does not contain the `REMOTE_USER` key.
(spotted when updated php from 7.4 to 8.0)
@giterlizzi giterlizzi self-requested a review November 30, 2022 11:31
Copy link

@PGtheG PGtheG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature should be merged soon. Its a little fix, which could prevent flooding of logs.
I've manually changed this line already to:

if ($this->getConf('showNavbar') === 'logged' && !isset($_SERVER['REMOTE_USER'])) {

@forthommel
Copy link
Contributor Author

Hello all,
We'll soon reach the 2yrs milestone for this open PR :) what shall we organise for its celebration?

@giterlizzi giterlizzi merged commit d252f52 into giterlizzi:master Oct 8, 2024
@forthommel
Copy link
Contributor Author

Thanks, @giterlizzi !

@forthommel forthommel deleted the patch-1 branch October 8, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants