Skip to content

Commit

Permalink
git-difftool--helper.sh: exit upon initialize_merge_tool errors
Browse files Browse the repository at this point in the history
Since the introduction of 'initialize_merge_tool' in de8dafb
(mergetool: break setup_tool out into separate initialization function,
2021-02-09), any errors from this function are ignored in
git-difftool--helper.sh::launch_merge_tool, which is not the case for
its call in git-mergetool.sh::merge_file.

Despite the in-code comment, initialize_merge_tool (via its call to
setup_tool) does different checks than run_merge_tool, so it makes sense
to abort early if it encounters errors. Add exit calls if
initialize_merge_tool fails.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
  • Loading branch information
phil-blain committed Nov 11, 2024
1 parent 74b83ca commit be0b86f
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions git-difftool--helper.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ launch_merge_tool () {
export BASE
eval $GIT_DIFFTOOL_EXTCMD '"$LOCAL"' '"$REMOTE"'
else
initialize_merge_tool "$merge_tool"
# ignore the error from the above --- run_merge_tool
# will diagnose unusable tool by itself
initialize_merge_tool "$merge_tool" || exit 1
run_merge_tool "$merge_tool"
fi
}
Expand All @@ -87,9 +85,7 @@ if test -n "$GIT_DIFFTOOL_DIRDIFF"
then
LOCAL="$1"
REMOTE="$2"
initialize_merge_tool "$merge_tool"
# ignore the error from the above --- run_merge_tool
# will diagnose unusable tool by itself
initialize_merge_tool "$merge_tool" || exit 1
run_merge_tool "$merge_tool" false

status=$?
Expand Down

0 comments on commit be0b86f

Please sign in to comment.