Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom path for .env file #117

Merged

Conversation

Gaardsholt
Copy link
Contributor

No description provided.

Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
@karpikpl
Copy link
Collaborator

Hey @Gaardsholt is that change for local development ?
I don't really see a point of changing the path for the .env file, as it's not supposed be copied into the container but is used as a source of environment variables

so in your example:

Or with custom path for your .env file:

docker run -it --rm -p 8080:3000 \
-e DOTENV_CONFIG_PATH=/custom/.env \
-v /path/to/your/.env:/custom/.env \
copilot-metrics-viewer-with-proxy

that could be done by:

docker run -it --rm -p 8080:3000 \
--env-file /custom/.env \
copilot-metrics-viewer-with-proxy

@Gaardsholt
Copy link
Contributor Author

It's because we get all of our secrets from an external system, so in order to get the environment variables when running in Kubernetes we have to do it like this

@karpikpl karpikpl merged commit e81bc24 into github-copilot-resources:main Nov 21, 2024
@Gaardsholt Gaardsholt deleted the dotenv_config_path branch November 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants