TypeScript repo classified as JavaScript #5249
-
|
I rewrote my repo in TypeScript today, but my
When rewriting the files I used |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 4 replies
-
Nope. This is the Search behaviour playing up and not Linguist (you should see that it is only the search results showing this). This is the same issue that affects #5052 and your previous discussion at #5220 I opened an internal issue off your last discussion and I've since learnt the reason for this: the search functionality was written in Go and is using an old fork of https://github.com/src-d/enry taken before it was forked off into the publicly maintained https://github.com/go-enry/go-enry. Our older fork has changes equivalent to Linguist v7.2.0 so is missing a whole lot of the newer languages etc. Work is underway to get our changes up-streamed and then we'll switch over to using it instead at which point Search will start reflecting what the language bar does. There's no timeline on when this will happen though. |
Beta Was this translation helpful? Give feedback.
-
|
The language bar is also not showing TypeScript, though, so it is Linguist. |
Beta Was this translation helpful? Give feedback.
-
|
🤦 I missed that. Looking at the file, it's because of your shebang:
... not Typescript: |
Beta Was this translation helpful? Give feedback.
-
|
Huh, interesting. Looking at this search query I'm not the only one who gets their repo misclassified when you add the Node shebang. Which is valid syntax, by the way (microsoft/TypeScript#2749), and is the only way I can see to get my TS scripts to work in Node when compiled without adding any overhead. It's even encouraged, and projects like this are forced to use the shebang as otherwise the file cannot be run as a CLI. Should I make a PR adding node to the TS interpreters? This is very common and in the cases of making a CLI, the only easy option. |
Beta Was this translation helpful? Give feedback.
-
|
Since this is an issue I'll reopen this as one for better tracking. |
Beta Was this translation helpful? Give feedback.
Nope. This is the Search behaviour playing up and not Linguist (you should see that it is only the search results showing this). This is the same issue that affects #5052 and your previous discussion at #5220
I opened an internal issue off your last discussion and I've since learnt the reason for this: the search functionality was written in Go and is using an old fork of https://github.com/src-d/enry taken before it was forked off into the publicly maintained https://github.com/go-enry/go-enry. Our older fork has changes equivalent to Linguist v7.2.0 so is missing a whole lot of the newer languages etc.
Work is underway to get our changes …