Some PHP files detected as Hacklang

[theel0ja]

Preliminary Steps

Please confirm you have...

• reviewed How Linguist Works,
• reviewed the Troubleshooting docs,
• considered implementing an override,
• verified an issue has not already been logged for your issue (linguist issues).

Problem Description

URL of the affected repository:

https://github.com/theel0ja/IPLookup/blob/fc18200e8678a3cc9fc071ecd6be10c8b95a3a10/src/add-to-flagfox.php

Last modified on:

2018-08-04

Expected language:

PHP

Detected language:

Hack

[pchaigno]

Thanks for the report.

Hack files can also use the .php extension. Since Linguist considers each file independently and that file only contains HTML code, it's going to be difficult (impossible?) for Linguist to understand that it is not a Hack file. You can use an override to change that behavior though.

[theel0ja]

I mean it detects PHP files that contain only HTML as Hack files

[pchaigno]

Yep, .php files can be either PHP or Hack since both languages use that extension. Linguist usually relies on the content to distinguish between the two. Since the file contains only HTML code, it fails to do so properly.

[Arkanic]

hey
i have this problem
https://github.com/Arkanic/warriorcats

[lildude]

@Arkanic #4229 (comment) applies to your case too.

[iMaz1n]

hey
i have this problem
https://github.com/Arkanic/warriorcats

cause you created a php file that doesn't contain php code, so you need to add some php code

[yannikbloscheck]

Yep, .php files can be either PHP or Hack since both languages use that extension. Linguist usually relies on the content to distinguish between the two. Since the file contains only HTML code, it fails to do so properly.

If it can't really decide based on the content, the fallback language should still be the far more popular and original language for that file extension. This is PHP and not Hack. I find the current behaviour very confusing. Took me some time to finally find this issue with an explanation.

[Hnnx]

I don't mind, it makes me look like I'm using some super secret language while.
Also experiencing this on certain .php files

[geraldelorm]

Thank you

[iotstudent]

Thanks for this explanation

[przemub]

Should not it be detected as HTML then? What Hack has to do with this?

[ismailalabou]

helpful

[pierreminiggio]

Hello !
Same issue on this private repo : https://github.com/pierreminiggio/kevin

[luisfelipesdn12]

Now overrides documentation is in: https://github.com/github/linguist/blob/master/docs/overrides.md