Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support crontab syntax #6547

Closed
haxwithaxe opened this issue Sep 13, 2023 · 2 comments · Fixed by #6759
Closed

Support crontab syntax #6547

haxwithaxe opened this issue Sep 13, 2023 · 2 comments · Fixed by #6759
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist

Comments

@haxwithaxe
Copy link

This is a super low priority for me. I just want crontab syntax highlighting in my README.md's on GitHub which claims to use this library. If that's true, then thank you. I'm very happy with your work. If not then this is just a common config/code format that you don't support yet.

Language name

crontab

URL of example repository

If you mean an example implementation of the syntax highlighting.
https://github.com/vim/vim/blob/6ffcc58be32aa1b337bc839cfe173b68cfde7085/runtime/syntax/crontab.vim
If you mean examples of crontab files I can provide those as needed. I didn't find any comprehensive examples in a moderately quick search.

URL of syntax highlighting grammar

I'm not aware of a formal highlighting specification. Below are a couple example syntax highlighting implementations.
https://github.com/vim/vim/blob/6ffcc58be32aa1b337bc839cfe173b68cfde7085/runtime/syntax/crontab.vim
https://github.com/textmate/cron.tmbundle/blob/master/Syntaxes/Crontab.tmLanguage < I've never used this one but it's another example

Most popular extensions

I don't know what is meant by this. I suspect that there are no extensions to the crontab format.

Detected language

Crontab files are detected as the crontab filetype by vim/neovim.

@haxwithaxe haxwithaxe added Add Language Good First Issue This is a great opportunity to start contributing to Linguist labels Sep 13, 2023
@Alhadis
Copy link
Collaborator

Alhadis commented Sep 13, 2023

I don't know what is meant by this. I suspect that there are no extensions to the crontab format.

That section's referring to file extensions (as in, .txt, .sh, .html, etc). To my knowledge, crontab files don't use any particular filename suffix.

That TextMate grammar looks pretty good, BTW:

Figure 1

@haxwithaxe
Copy link
Author

Ah, yeah. I've never seen a crontab with a file extension. When you run crontab -e it creates a file named crontab in a temporary directory.
I prefer the vim version of the highlighting. It colorizes the columns which is handy in big crontabs.

Nixinova added a commit to Nixinova/fork_linguist that referenced this issue Mar 17, 2024
@Nixinova Nixinova mentioned this issue Mar 17, 2024
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 7, 2024
* Add Crontab language

Resolves #6547

* Use 'TCL' ace mode

Co-authored-by: John Gardner <gardnerjohng@gmail.com>

* Add colour

Co-authored-by: John Gardner <gardnerjohng@gmail.com>

* Fix test runner errors

* Fix grammar key

* Update vendor/licenses/git_submodule/cron.tmbundle.dep.yml

---------

Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Co-authored-by: Colin Seymour <colin@github.com>
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Sep 17, 2024
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants