-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Highlighting for Igor #4568
Conversation
The Igor Syntax Highlighting was removed due to a missing *.tmlanguage file. The language recognition is still present but it currently does not highlight the code on github.
Thanks for the pull request @ukos-git! Could you please add the template back and fill it? That helps for reviews. |
I added a few examples using lightshow. Highlighting of Another note: Igor has very specific highlighting colors from the vendors. Is there a more specific way to define the colors? |
Indeed, submodules are updated with each new release of Linguist. Probably best to update it anyway though, just in case we miss it in the next release.
No. Grammars let you decide the scope of each token but the style (i.e., colors of scopes) is defined by GitHub. |
Click to show table (it's huge)
Just weighing in on this: here's the list of scope-to-CSS-class mappings in-use by GitHub as of this writing. Important notes
|
@Alhadis Thanks, that was really helpfull. The highlighting now looks much more alike. I have created a tiny php script to get the closest matching colors. PR ready. |
Description
The Igor Pro Syntax Highlighting had been added in 2013 / 2014 and was removed when moving linguist to tm based highlighting due to missing
*.tmlanguage
file. The language recognition is still present but it currently does not highlight the code on github.
There was a demand from the Igor programmers community pending since 2017 and also stale issues here.
There are quite a few Projects on Github, although the language is very specific to the scientific community. As the program itself is not open source, there are also fewer spread Open Source projects. Nevertheless, it suffices the requirement for adding the language to linguist.
I have added a tm syntax highlighting under BSD-3 on github so I think it is time to get the highlighting for Igor back to github.
Checklist: