-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for checksum lists #5138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have yet to verify the usage of each addition, but here're some preliminary thoughts.
These names are too ubiquitous across GitHub, and code-searches yield no actually valid files containing a CRC32 sum. See http://github.com/github/linguist/pull/5138/files/09c642Ω#r559949817 for the original discussion justifying their removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lildude, I'm passing this ball to your court, as you're currently responsible for sussing out popularity metrics. Hopefully it's not too much of a pain. 😁
With this many filenames and extensions, it's a right PITA!! 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few file names that I couldn't find a single example of or aren't popular enough when I did.
I agree with the suggestions and have made them. I noticed a lot of results for extension Also, I noticed some files in the format |
Yes, there are quite a few, however the format isn't consistent from a quick look at various results. I'm not sure if the grammar can support this at this stage and I'd really like to build the next release today. We can always add it later once @Alhadis confirms the grammar can support these various formats. Accordingly, I've removed the |
Yes, I agree. It's better to merge this first and open a new issue/PR for later changes. |
Well, I can add support for patterns like this…
… however, I'm unfamiliar with whatever program generates this kind of output, and I'd ideally like some authoritative reference on what formats are accepted in such lines (the example looks to be using base64, but I'd rather not go by guesswork if I can help it).
There's no foolproof way to tell |
— @Alhadis
— ibid
Description
Fixes #5130.
Checklist
.sha256
: ~789,426 results.crc
12,509.crc32
5,262.digest
3,071.md2
41,384 (3D model files need to be excluded).md4
120.md5
4,906,611.rmd160
49.sha1
2,782,935.sha2
423.sha224
224.sha256
789,426.sha3
28.sha384
3,685.sha512
154,632SHA1SUMS
3,921SHA256SUMS
2,148