-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the BASIC family of programming languages #5166
Conversation
Your query searches for Do members of the BASIC family generally use all-caps |
@zspitz Correct, the GitHub search is case-insensitive, which is why I also included 10 20 30 in the search. Line numbers in BASIC programs are often (but certainly not always) chosen to be multiples of 10. The search is not all-inclusive but it does provide clear evidence that BASIC programs have been incorrectly labeled as Visual Basic .NET or VBA. Some dialects of BASIC are case-insensitive while others are case-sensitive, requiring uppercase keywords. Even in dialects of BASIC that are case-insensitive, programs are sometimes written entirely in uppercase anyway. |
@lildude Any update on this pull request? |
I was waiting for you to address the failing tests as the PR isn't complete whilst they're failing. |
@lildude OK, all checks have passed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙇
Description
As I reported in #5156, many BASIC programs have been incorrectly labeled as VBA (or Visual Basic .NET if they have not been updated since #4725). There are numerous dialects of BASIC (e.g. AppleSoft, Commodore, GW-BASIC), but most dialects share similar syntax and reserved words, and all dialects are collectively known as BASIC. At the very least, a file with the extension
.bas
and line numbering should be labeled as BASIC rather than Visual Basic .NET or VBA. Therefore, I have added a BASIC language along with an appropriate grammar and sample, and I have added a heuristic to check for line numbering.Checklist