Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TL-Verilog #5331

Merged
merged 6 commits into from
May 30, 2023
Merged

Add TL-Verilog #5331

merged 6 commits into from
May 30, 2023

Conversation

adamint
Copy link
Contributor

@adamint adamint commented Apr 19, 2021

This PR is to add TL-Verilog, an EDA language that transpiles to SystemVerilog and Verilog.

A little about TLV
TL-Verilog is rapidly gaining popularity for digital logic design, as an extension to Verilog (the predominant logic design language). TL-Verilog is utilized within the makerchip.com and edaplayground.com platforms and is supported by tl-x.org. GitHub integration for Makerchip is in the works.

The most popular TL-Verilog projects are:

RISC-V International lists popular RISC-V CPU core implementations, including two in TL-Verilog: https://riscv.org/exchange/cores-socs/, one from above, and one from training classes.

Thousands of students have developed using TL-Verilog in online courses:

Checklist:

@adamint adamint requested a review from a team as a code owner April 19, 2021 13:36
@lildude
Copy link
Member

lildude commented Apr 23, 2021

Thanks for the PR. If we use your heuristic to filter the search results - like this - we get only 32 files on the whole of GitHub. This is a long way from our minimum requirement of 200 unique :user/:repo repositories so we can't accept this PR right now. Given the very low numbers it's probably best to close this PR and open a new one once usage meets our requirements.

@adamint
Copy link
Contributor Author

adamint commented Apr 23, 2021

@lildude I'm not sure you put in the right search 😄 \TLV_version and \m4_TLV_version are both supported (and anything actually before TLV)

@lildude
Copy link
Member

lildude commented Apr 26, 2021

🤦 I missed that the search has changed and isn't matching the TLV_version part of m4_TLV_version. That said, adjusting the search to take this into account extension:tlv TLV version and pull in even more results which may not all be TL-Verilog files stills comes up considerably short:

Total files found: 457
Unique public user/repos: 81
Unique owners: 47

Even adding together the two individual specific searches doesn't meet the threshold yet:

Total files found: 32
Unique public user/repos: 3
Unique owners: 3

Total files found: 405
Unique public user/repos: 77
Unique owners: 41

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like things are popular enough to merge this PR. Please merge in master and address the conflicts.

@lildude
Copy link
Member

lildude commented Nov 14, 2022

Looks like things are popular enough to merge this PR. Please merge in master and address the conflicts.

Or you can grant me write access and I'll do it.

@lildude
Copy link
Member

lildude commented Feb 17, 2023

Please resolve the merge conflicts or grant me write access so we can merge this PR.

@lildude lildude added Stale and removed Stale labels Feb 17, 2023
@lildude lildude requested a review from a team as a code owner May 30, 2023 09:27
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit 487ef61 May 30, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants