Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSC #5634

Merged
merged 7 commits into from
Feb 10, 2022
Merged

Add GSC #5634

merged 7 commits into from
Feb 10, 2022

Conversation

Jake-NotTheMuss
Copy link
Contributor

@Jake-NotTheMuss Jake-NotTheMuss commented Nov 4, 2021

Description

GSC is a programming language used for Call of Duty's virtual machine.

Checklist:

@Jake-NotTheMuss Jake-NotTheMuss requested a review from a team as a code owner November 4, 2021 09:47
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've only listed three sample files in the OP but have added more. Please update the OP to list where you've obtain all of the sample files and their respective licenses.

@Jake-NotTheMuss
Copy link
Contributor Author

The other files are directly from the Black Ops 3 mod tools. I think it's GNU v3 but I'll install Black Ops 3 to make sure and update with the license for those files when I confirm.

@Jake-NotTheMuss
Copy link
Contributor Author

I've added the license for the other samples, but the syntax highlighting grammar that was given is provided in the mod tools, so I guess that means it's licensed under GPL 3, so I will create my own with an acceptable license.

@lildude
Copy link
Member

lildude commented Dec 9, 2021

I've added the license for the other samples, but the syntax highlighting grammar that was given is provided in the mod tools, so I guess that means it's licensed under GPL 3, so I will create my own with an acceptable license.

Thanks. Can you update the OP to point to the source of the files too, as you've done with the current three files.

As for the grammar, the one you've added - https://github.com/Jake-NotTheMuss/CoDT7-Sublime.git - is covered by the Unlicense License, which is fine.

I still need to check usage levels of all extensions meet our requirements.

@Jake-NotTheMuss
Copy link
Contributor Author

Those scripts aren't on the Internet. Should I create a repo and push those files to it? And the license of the sample files can be anything, right?

@Jake-NotTheMuss
Copy link
Contributor Author

The rest of the sample files and their license have been added.

@lildude lildude requested review from Alhadis and lildude December 10, 2021 17:02
@Jake-NotTheMuss
Copy link
Contributor Author

Should I add tests for each GSC extension to test/test_heuristics.rb?

@Jake-NotTheMuss
Copy link
Contributor Author

@lildude

@lildude
Copy link
Member

lildude commented Dec 17, 2021

Should I add tests for each GSC extension to test/test_heuristics.rb?

That's what the test failure is telling you 😉

Or you can remove the heuristics if these extensions are unique to this language.

@Jake-NotTheMuss
Copy link
Contributor Author

@lildude I added the heuristic tests for each extension. These extensions are not associated with any other supported language on github, but they are there just be certain non-GSC .gsc files aren't counted.

@Jake-NotTheMuss
Copy link
Contributor Author

@lildude Do I need to run the tests again or is there something else I need to do first?

@Jake-NotTheMuss
Copy link
Contributor Author

@Alhadis

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is probably close to being merged based on the new temp limits detailed in #5756 however these samples are quite massive.

samples/GSC/array_shared.gsc Outdated Show resolved Hide resolved
samples/GSC/scene_shared.csc Outdated Show resolved Hide resolved
samples/GSC/shared.gsh Outdated Show resolved Hide resolved
@Jake-NotTheMuss
Copy link
Contributor Author

This PR is probably close to being merged based on the new temp limits detailed in #5756 however these samples are quite massive.

Samples should be a good size now

@lildude
Copy link
Member

lildude commented Feb 9, 2022

@Alhadis would you mind taking a quick look at the regexes in this PR when you've got a mo? 🙇

lib/linguist/heuristics.yml Outdated Show resolved Hide resolved
lib/linguist/heuristics.yml Outdated Show resolved Hide resolved
lib/linguist/heuristics.yml Outdated Show resolved Hide resolved
lib/linguist/heuristics.yml Outdated Show resolved Hide resolved
@Jake-NotTheMuss
Copy link
Contributor Author

@lildude @Alhadis

@lildude lildude merged commit 7469c79 into github-linguist:master Feb 10, 2022
kalkin added a commit to kalkin/file-expert that referenced this pull request May 17, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants