-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GSC #5634
Add GSC #5634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've only listed three sample files in the OP but have added more. Please update the OP to list where you've obtain all of the sample files and their respective licenses.
The other files are directly from the Black Ops 3 mod tools. I think it's GNU v3 but I'll install Black Ops 3 to make sure and update with the license for those files when I confirm. |
I've added the license for the other samples, but the syntax highlighting grammar that was given is provided in the mod tools, so I guess that means it's licensed under GPL 3, so I will create my own with an acceptable license. |
Thanks. Can you update the OP to point to the source of the files too, as you've done with the current three files. As for the grammar, the one you've added - https://github.com/Jake-NotTheMuss/CoDT7-Sublime.git - is covered by the Unlicense License, which is fine. I still need to check usage levels of all extensions meet our requirements. |
Those scripts aren't on the Internet. Should I create a repo and push those files to it? And the license of the sample files can be anything, right? |
The rest of the sample files and their license have been added. |
Should I add tests for each GSC extension to test/test_heuristics.rb? |
That's what the test failure is telling you 😉 Or you can remove the heuristics if these extensions are unique to this language. |
@lildude I added the heuristic tests for each extension. These extensions are not associated with any other supported language on github, but they are there just be certain non-GSC .gsc files aren't counted. |
@lildude Do I need to run the tests again or is there something else I need to do first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is probably close to being merged based on the new temp limits detailed in #5756 however these samples are quite massive.
Samples should be a good size now |
@Alhadis would you mind taking a quick look at the regexes in this PR when you've got a mo? 🙇 |
Description
GSC is a programming language used for Call of Duty's virtual machine.
Checklist: