-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Gleam programming language #5688
Conversation
Hi @lildude! Sorry to ping you, but is there anything else the Gleam folks need to do here before this addition can be considered? Thank you |
I'm not performing reviews of PRs until I've got the time to start working on the next release (likely to be in early Feb at the earliest). From a quick look, all looks good, however I suspect the lack of usage is going to hold back merging this PR immediately. We'll see when I get to reviewing. |
Thank you |
Use looks too low, even with our temporarily eased requirements as detailed in #5756 |
Hi @lildude! I anticipated that where would be be an issue with the new search so I took the time to add over 200 Gleam projects to a list and linked it with my post: https://github.com/stars/lpil/lists/gleam-projects We have the 200 repos required to meet the previous inclusion criteria. Seeing as the search is not needed with the aid of the list the existing metric could be used. Will that be enough for our inclusion? Thanks, |
I have an additional 2 Gleam focused repos that I don't think are on that list: (actually 3 but one of them is private) |
Thank you @aslilac 💜 |
@lpil I was using the simple search you included in the OP to see the number of files, which is less than the new temp 2000 file limit. If you can improve that, please do. |
Hi @lildude, is it not possible to use the traditional 200 user/repo requirement in this instance then? It is a little frustrating the requirement has been made stricter after this PR was opened, especially since we have manually collected 200+ repos as evidence. If it is not sufficient how do we find out how many files there are? The search doesn't show a number for me beyond 1000+ so I'm not sure how many are required. I also tried the new search and it doesn't show a number beyond 100, and the pagination stops entirely after 5 pages. Thanks |
I didn't state it wasn't sufficient... I stated that was how I determined it didn't meet the new search criteria 😉 I didn't notice your manually curated list in the OP, but now you've pointed it that should be sufficient.
It should do... right at the top: |
oh I see! Sorry for the confusion there. Thank you 💜
I've no idea how I missed that. I think you can tell I've not had my coffee yet this morning 😵 |
Description
Hello! 👋
I would like to add support for the Gleam programming language.
Checklist:
We hope to have a tree-sitter grammar in the near future, but for now we have a textmate one.
Thank you! 💜