-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language Skript #5726
Add language Skript #5726
Conversation
Add the 'Skript' Programming Language
This file was added by mistake.
Also, adding on to the color, this is the official color for the Script language, which is plastered all over the Documentation. |
Alright @Nixinova , I added the new sample files. |
Those new samples should be good. You'll have to update the OP listing where they're from tho if they are taken from somewhere else. |
Awesome! |
Hey @Alhadis can you review this? |
@blockarchitech I'll need to review the distribution of I'll get back to you. |
Reading the guidelines on heuristics, I have to run the Bayesian classifier, and the guidelines said to ping @lildude to help with this. |
Heuristics are only necessary when there are multiple (eligible) languages with the same file extension(s) and/or filename(s). They're not necessary for every addition, and the part about benchmarking the classifier is only relevant for complex heuristics… I think. The main issue I need to address is the possibility of as-yet undiscovered formats with the In other words, don't worry about if for the time being. 😉 |
Okay so @Alhadis I went through most of the search results and found that a lot of the results were skript, but some weren't. I'll create an excel document with a chart to better visualize this tomorrow. |
You might want to hold off on that too, as there was a recent (temporary) change in Linguist's eligibility assessment. See #5756. |
Okay, that's going to make my life a LOT easier even outside of linguist. Just signed up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you missed adding the grammar license file. When you ran script/add-grammar
it should have downloaded the file in a format we need.
Hello, I'm here in an official capacity from SkriptLang, the org that maintains the Skript language. We have some major concerns about this PR: It should also be noted that neither the highlighter grammar vendor linked nor the sample files are officially created/maintained - both are provided by third parties not affiliated the language maintainers. While we'd be honoured to have linguist support Skript, we want to make sure that the language is represented accurately and reliably. |
I'll address these sample files, for sample2 I did not know it relied on a 3rd-party module. sample1 I'm not sure I understand your claim as this was a tested file, but I can go ahead and make a new one.
Grammar has been updated. Thanks for your concern, and letting me know. I'll go ahead and get these added ASAP. |
Quick Update: The folks over at SkriptLang (big thanks @Moderocky ) have been working on official grammar. On stable release I'll get this updated and re-request another review. Repo |
Ah, please ignore the double-merge, did once on GitHub and |
Will work on in a new pull request as there's some sorting issues with this fork |
Description
This will add syntax highlighting, and language identification of the language Skript across GitHub.
Checklist: