-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JsLIGO support #5908
base: master
Are you sure you want to change the base?
Add JsLIGO support #5908
Conversation
@pewulfman @lildude @Alhadis can you review this? |
Usage of the I'm happy to accept the other changes if you want to split the change of grammar from the addition of the new extension. |
Can you please also update the OP to link to the source of the sample and explicitly stated the license of the file. |
I did not completely understand, do you mean I need to add license information to the provided sample like |
Nope. Just fill in this part of the template that you've left empty:
|
I'll move this PR to Draft state for now, we are expecting the usage of In a few months once we have enough usage of |
Hey @lildude I see in the search query some users are excluded https://github.com/search?p=6&q=extension%3Ajsligo+-user%3Aemacsmirror+-user%3Aligolang+-user%3Atezos-checker+-user%3Amarigold-dev+-user%3Asmart-chain-fr+-user%3ADiningPhilosophersCo&type=Code |
Yes. That's removing the biggest contributors so we can get a better idea of overall usage as GitHub's search is struggling at the moment. See #5756 for the temporary criteria were using. |
@lildude I am surprise about the user list that you removed from the query. I mean I understand that you remove ligolang but what about the others ? can you elaborate ? What would be the minimum number of users and code files required to accept the PR ? The guideline says 200 user/repo |
I'll start with this question...
The 200 unique With that in mind, I'll answer:
This is answered in #5756:
To further elborate, I removed those just to demonstrate that of the current 1542 files on GitHub, six users are responsible for 1504 of them. This suggests the usage on GitHub is primarily isolated to a few users and not an a good indication of wide-spread adoption yet which is what we're aiming for. |
Hey @lildude It's been around a year since I raised this PR, I see now there are 237 files according to this search url. I am not able to find the number of users using Also is the current usage of Thanks. |
That's still very low, especially considering a repo can have multiple Using the new search (it is still indexing repos from most recently active to least recently active so won't include everything yet)
I used to use a script but this is no longer possible due to problems with the old code search and the reason for the change in process as documented in #5756 So things are still not popular enough for inclusion. |
Cool, Thanks for your response @lildude |
Hi @lildude, Checking for this topic. Looks like your request with extension got partial result for example this search result to 0 code, but this repo got Looks like I triggered manually indexation with But is the search request relevant ? Are you using another way to extract the number of distinct |
@Laucans No, I don't know how indexation works. This is maintained by a completely different team but I understand things will take time to index since we switched to using the new search functionality as active repositories are being prioritised with less active repos slowly being added as they're accessed or as the backlog is processed.
The search is still relevant (it needs slight tweaking to exclude forks) and I'm still using the same temporary approach I previously referenced as there still isn't an easy way to calculate the distinct repos. |
Description
Checklist: