Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change grammar source for Svelte #5963

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

3ventic
Copy link
Contributor

@3ventic 3ventic commented Jul 5, 2022

Description

Changes the source for Svelte from a seemingly abandoned fork to the original, active, repository. This change is prompted by a bug in the grammar; the fork has disabled issues, and the original repository has since added a compatible license (MIT) and commits, which possibly fix my issue.

Checklist:

@3ventic 3ventic requested a review from a team as a code owner July 5, 2022 15:31
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the script/add-grammar script to replace the grammar and add the updated cached license produced by that script to this PR.

@3ventic
Copy link
Contributor Author

3ventic commented Jul 11, 2022

@lildude That is what I did. Running the script only results in ordering difference in .gitmodules.

This was the exact command used with no further changes in the branch:

script/add-grammar --replace vendor/grammars/svelte-atom https://github.com/sveltejs/svelte-atom

@lildude
Copy link
Member

lildude commented Jul 11, 2022

🤔 it should have downloaded the license file here:

https://github.com/github/linguist/blob/6cf57c870ec7a7c56835a3532a1df6149c3c8d93/script/add-grammar#L133-L134

If it didn't, it's possible the script failed before it got to that point.

@lildude
Copy link
Member

lildude commented Jul 11, 2022

Hmmm, I've just run it myself and even manually ran the bundle command and it doesn't update the license. 🤔

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 Tests are passing so I'm happy 😁

@lildude lildude merged commit 1541433 into github-linguist:master Jul 11, 2022
@lildude lildude changed the title Change source for svelte Change grammar source for Svelte Jul 11, 2022
@3ventic 3ventic deleted the svelte-official branch July 11, 2022 11:01
lildude added a commit that referenced this pull request Nov 24, 2022
lildude added a commit that referenced this pull request Nov 28, 2022
Revert "Change grammar source for Svelte (#5963)"

This reverts commit 1541433.
@lildude lildude mentioned this pull request Nov 28, 2022
3 tasks
jewell4003

This comment was marked as spam.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants