-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .wx
extension to Monkey language
#5964
Conversation
Added Wonkey extension to Monkey language
.wonkey
extension to Monkey language
.wonkey
extension to Monkey language.wx
extension to Monkey language
First, please fill out the pull-request template. It's there for a reason. Second, a little background on what "Wonkey" is would be nice. I notice that you're adding |
OK, i have updated my pull request description with more informations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have included a real-world usage sample for all extensions added in this PR:
No you haven't 😉 Please add the sample to the PR.
I'd add the sample myself, however you've not granted maintainers write access to your branch so I can't. Accordingly, this PR will miss the release I'm making today. |
@lildude , Ok i added a Vec2 sample
It seems not possible to "Allow edits from maintainers" from organization account pull request, see https://github.com/orgs/community/discussions/5634. |
Where did you get this from? Please update the OP to link directly to the file. |
Link updated and i added this file in PR. |
Errm, we need a link to the original source, not your fork of Linguist 😉 |
Cause i have added this file in this pull request but ok i have changed link from original |
🤔 those two files don't match. If you've written the sample explicitly for this PR, then that's fine. You can state that instead of linking to a source. |
I explicitly added a sample file in my linguist fork in the "samples/Monkey/vec2.wx" folder and integrated it into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me
@lildude Do you expect other actions from me before to merge this PR? |
I've finally looked into the usage and there are a couple of issues: Your search string suggests usage is nowhere near popular enough with only 904 file, most of which are owned by one user. Removing that user gives only 162 files indexed which is a long way from the documented and even temporarily relaxed requirements. I've tried several other combinations of the search for Wonkey specific keywords and I can't find a result that satisfies the requirements. If you can generate a representative search, please do so. More importantly... inverting your search to exclude the word "import" (and exclude the wonkey-coders user) reveals this is going to misclassify a lot of other users of the In order to prevent this, you're going to need to identify at least one of those languages and add support to this PR along with two representative samples of both languages to ensure the classifier has a chance of getting things right. If the two languages are similar, you will need to implement a heuristic too. |
Ok i've changed search filters by adding original "Monkey, Monkey2" extensions and removing 'import' keyword because is a same language, only extension name has been simplified for Wonkey. |
It's not that complicated... it's just that we need to ensure each extension meets the popularity requirements before inclusion so adding the Monkey extensions to your query doesn't help illustrate the popularity of the |
@lildude I've reduced extension filter to only '.wx' and of course, Wonkey is not the only one to use this extension, should we add more code examples to facilitate the classification or it would not be useful? |
Yes. I think we're also going to need to identify the other predominant user of this extension and add support for it with at least two samples to this PR too. |
I added more Wonkey samples |
Woah! Some of those are bigger than we need. If the diff view collapses the file, it's too big. Please remove these large samples. You're still going to need to identify the language of at least one other user of the |
OK i've removed large sample files.
I've updated the PR. |
👆 |
Closing as the requested changes have not been made in well over a year since being requested. Please open a new PR when you have the time to make the requested changes. |
Added Wonkey extension to Monkey language.
Description
Wonkey is a up to date fork of Monkey2 programming language for the creation of cross-platform video games (very similar to BlitzBasic/BlitzMax but with oriented object programming).
preview:
Wonkey : https://github.com/wonkey-coders/wonkey
Monkey2 : https://github.com/blitz-research/monkey2
Checklist:
samples/Monkey/vec2.wx