-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sophia smart contract language #5982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the contrived samples/Sophia/all_syntax.aes
sample. We prefer real-world samples as they're more reflective of real-world usage.
The grammar license file appears to be manually curated and not from using the add-grammar
script. Please add the file created by that script when you ran it in place of the current file.
If you don't have the file, running bundle exec licensed cache -c vendor/licenses/config.yml
should generate it.
Update: please also update the OP to link to the original sources of the samples and not the files added to your fork of this repo.
cool to see this being tackled, thanks for the PR @zxq9! 😎 in case some other real examples are needed:
not sure though if https://github.com/mradkov/vscode-sophia is up to date. maybe @radrow, @ghallak or @hanssv can confirm that. anyway, can't wait to finally see syntax highlighting for Sophia on GitHub <3 |
Yet another real-life example: https://github.com/aeternity/hyperchains-contract/blob/master/contracts/Election.aes |
@marc0olo The VS code extension is slightly outdated (eg it lacks |
Thanks for the heads up @radrow , I'll give the new syntax elements a look and update this. |
@zxq9 the syntax highlighting grammar is about to be updated to the latest state 😃 see mradkov/vscode-sophia#9 |
Nudge nudge @zxq9. This PR is still waiting on you. It won't be merged until you address the requested changes. |
Closing as stale. |
This PR adds support for the Sophia contract language.
Checklist: