Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sophia smart contract language #5982

Closed
wants to merge 2 commits into from

Conversation

zxq9
Copy link

@zxq9 zxq9 commented Jul 19, 2022

This PR adds support for the Sophia contract language.

Checklist:

@zxq9 zxq9 requested a review from a team as a code owner July 19, 2022 12:04
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the contrived samples/Sophia/all_syntax.aes sample. We prefer real-world samples as they're more reflective of real-world usage.

The grammar license file appears to be manually curated and not from using the add-grammar script. Please add the file created by that script when you ran it in place of the current file.

If you don't have the file, running bundle exec licensed cache -c vendor/licenses/config.yml should generate it.

Update: please also update the OP to link to the original sources of the samples and not the files added to your fork of this repo.

@radrow
Copy link

radrow commented Jul 29, 2022

Yet another real-life example: https://github.com/aeternity/hyperchains-contract/blob/master/contracts/Election.aes

@radrow
Copy link

radrow commented Jul 29, 2022

@marc0olo The VS code extension is slightly outdated (eg it lacks main keyword and <- from list comprehensions), but should work for most uses

@zxq9
Copy link
Author

zxq9 commented Aug 1, 2022

Thanks for the heads up @radrow , I'll give the new syntax elements a look and update this.

@lildude lildude linked an issue Sep 1, 2022 that may be closed by this pull request
@marc0olo
Copy link

@zxq9 the syntax highlighting grammar is about to be updated to the latest state 😃 see mradkov/vscode-sophia#9

@lildude
Copy link
Member

lildude commented Feb 17, 2023

Nudge nudge @zxq9. This PR is still waiting on you. It won't be merged until you address the requested changes.

@lildude lildude added the Stale label Feb 17, 2023
@lildude
Copy link
Member

lildude commented Jun 6, 2023

Closing as stale.

@lildude lildude closed this Jun 6, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sophia smart contract language
4 participants