-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Language: Imba #6080
Add Language: Imba #6080
Conversation
Please let me know if there is anything I can do to help get this process going. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the OP with the PR template, it's there for a reason. You're also going to need to find a different grammar or add a licence to the grammar as we can't accept grammars without a licence. The CONTRIBUTING.md file has a link to the acceptable licenses.
@lildude Thank you for reviewing. Edited my OP and added an MIT license to the grammar repo. |
Thanks. You're going to need to update the cached license file too. Re-adding the grammar by replacing it with itself using |
I ran
and waited about 3 minutes, after which |
🤔 Try committing the updated submodule and run |
I couldn't get it to work. I didn't want to take up too much of your time so I just decided to redo everything from scratch, and take the opportunity to move the grammar and sample repositories to the official Imba account. Here's the new PR: #6130. I hope you don't mind, I think it should be possible to diff this branch and the new PR so you don't have to read everything from scratch. This worked for me:
Thanks again for all your help. |
Closing in favour of #6130 |
Checklist: