Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Svelte grammar source #6216

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

sebastinez
Copy link
Contributor

@sebastinez sebastinez commented Dec 19, 2022

Description

This PR changes the svelte grammar from the unmaintained umanghome/svelte-atom repo to sebastinez/svelte-atom maintained by me and with the goal to add the newest features, until it eventually will get replaced by a tree-sitter implementation.

The grammar replacement was done with the script/add-grammar script

Checklist:

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
@sebastinez sebastinez requested a review from a team as a code owner December 19, 2022 10:41
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude changed the title Change Svelte grammar fork to sebastinez/svelte-atom Change Svelte grammar source Jan 1, 2023
@sebastinez
Copy link
Contributor Author

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

Thanks @lildude, much appreciated

@lildude lildude merged commit f8b4d33 into github-linguist:master Feb 17, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants