Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Rust grammar source #6220

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

sebastinez
Copy link
Contributor

@sebastinez sebastinez commented Dec 19, 2022

Description

Replace the zargony/atom-language-rust grammar submodule with dustypomerleau/rust-syntax, due to the former not being actively maintained.
This issue has been already talked about in this discussion as a good choice #5965 (comment).

This changeset has been created by the script/add-grammar script.

Since the upstream highlighting engine now implements the treesitter Rust grammar, I understand that this PR is not that high priority, but there are tools and packages downstream that take linguist as the their source.

Checklist:

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
@sebastinez sebastinez requested a review from a team as a code owner December 19, 2022 16:00
@sebastinez sebastinez changed the title Changing source of Rust grammar Replace zargony/atom-language-rust Rust grammar with dustypomerleau/rust-syntax Dec 19, 2022
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude changed the title Replace zargony/atom-language-rust Rust grammar with dustypomerleau/rust-syntax Change Rust grammar source Jan 1, 2023
@sebastinez
Copy link
Contributor Author

Thanks @lildude , much appreciated

@lildude lildude merged commit c3675dc into github-linguist:master Feb 17, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants