-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WDL's description #6319
Update WDL's description #6319
Conversation
* Fix name to show Workflow Description Language rather than just wdl (in line with cwl/Common Workflow Language) * Add two interpreters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix name to show Workflow Description Language rather than just wdl to put it in line with other languages (compare cwl/Common Workflow Language)
Is this language really more commonly referred to as "Workflow Description Language" in full than the "wdl/WDL" acronym?
We try to use the most commonly use term/name for languages. For example we use XML, HTML, CSS etc... as these are more commonly referred to by their acronyms than their full names and from a quick look of https://openwdl.org/ even they seem to refer to it more as wdl/WDL... the big fat logo at the top of the page is even "wdl".
If we were to go with this change, you'll also need to rename the samples directory.
This is a fair point! I was extrapolating from how this repo handles Common Workflow Language, usually shortened to CWL but showing as Common Workflow Language here. WDL is almost always referred to as WDL, so I'll revert that part. |
Revert WDL back to its more common name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're also going to need to address the test failures, namely changing the case of the directory that hold the samples and fixing the order in the README.
they're interpreters, but they're not used in shebangs, so they get cut Co-authored-by: Colin Seymour <colin@github.com>
Fix name to show Workflow Description Language rather than just wdl to put it in line with other languages (compare cwl/Common Workflow Language)See comments below. This does raise the question if CWL should be changed since it's usually called CWL in my experience, but I'll leave that to people more familiar with that language to make that call.WDL wasn't misclassified per say, so none of the checklists seem to apply?