Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust-script to Rust interpreters #6354

Merged
merged 2 commits into from
May 30, 2023
Merged

Add rust-script to Rust interpreters #6354

merged 2 commits into from
May 30, 2023

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Apr 1, 2023 •
edited by lildude
Loading

Detect rust-script files as rust source code.

Description

Detect files using the rust-script interpreter as Rust source code. Asked for here. See this GitHub search for examples of usage.

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

@fornwall fornwall requested a review from a team as a code owner April 1, 2023 19:55
@fornwall fornwall mentioned this pull request Apr 1, 2023
Closed
@Alhadis Alhadis changed the title Detect rust-script as rust Add rust-script to Rust interpreters Apr 2, 2023
Alhadis
Alhadis requested changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a source for the sample you've included? We need to be sure that it's been released under an open-source license.

@fornwall
Copy link
Contributor Author

fornwall commented Apr 2, 2023

Could you please provide a source for the sample you've included? We need to be sure that it's been released under an open-source license.

It was just a personal utility script of mine, which I hereby license under the MIT license.

@Alhadis Is that good enough, or would you rather prefer to pick a script from an existing repository?

@Alhadis
Copy link
Collaborator

Alhadis commented Apr 2, 2023

It was just a personal utility script of mine, which I hereby license under the MIT license.

That's perfectly fine. Just wanted to get that on record. 👍

lildude
lildude approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude requested a review from a team as a code owner May 30, 2023 09:15
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit c31f765 May 30, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Alhadis Alhadis Alhadis approved these changes

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fornwall @Alhadis @lildude