Add Nushell

[hustcer]

Description

Checklist:

• I am adding a new language.

  • The extension of the new language is used in hundreds of repositories on github.com.

    • Search results for each extension:
      • https://github.com/search?q=path%3A*.nu&type=code

  • I have included a real-world usage sample for all extensions added in this PR:

    • Sample source(s):
      • https://github.com/nushell/nushell/blob/main/.github/workflows/release-pkg.nu
      • https://github.com/nushell/nu_scripts/blob/main/make_release/this_week_in_nu_weekly.nu
    • Sample license(s): MIT

  • I have included a syntax highlighting grammar: Nushell Grammar

  • I have added a color

    • Hex value: #4E9906
    • Rationale: It's the main theme color of Nushell logo from: https://github.com/nushell

  • I have updated the heuristics to distinguish my language from others using the same extension.

[lildude]

How is Nushell different from Nu which Linguist already supports and has done so for many many years? From a cursory naïve look, it appears to be the same thing with Nushell often being referred to as Nu, even in the Nushell book.

[hustcer]

How is Nushell different from Nu which Linguist already supports and has done so for many many years? From a cursory naïve look, it appears to be the same thing with Nushell often being referred to as Nu, even in the Nushell book.

They are totally two different languages with the same name, and they are created by two different teams. That's why I updated lib/linguist/heuristics.yml to distinguish Nushell from Nu using the same extension.

[lildude]

Thanks for the clarification that this is a completely different language.

We need a few changes though:

1. Please update the template in the OP to state the licenses of the two samples and add a reason for why you have chosen the colour you have.
2. You need to add the cached license file for the grammar. This should have been created when you run script/add-grammar (you can manually run the command here if you can't find the file).
3. See inline comments.

[hustcer]

1. Please update the template in the OP to state the licenses of the two samples and add a reason for why you have chosen the colour you have.

I don't know what's OP. I have just updated the description of license for the two samples. And updated the color to #4E9906, that's the main theme color of nushell logo from: https://github.com/nushell

2. You need to add the cached license file for the grammar. This should have been created when you run script/add-grammar (you can manually run the command here if you can't find the file).

Added

3. See inline comments.

I have removed .nush extension (It's planed to be used in the future, we can add it after that)
For the other two comments, does that mean the Nushell scripts be recognized as Nu language? We may want to be recognized as Nushell to make it different from Nu

[lildude]

I'm showing my age: OP == original post 😁

For the other two comments, does that mean the Nushell scripts be recognized as Nu language? We may want to recognized as Nushell to make it different from Nu

No. We need to ensure that your heuristics do not incorrectly identify Nu files as Nushell.

The heurstics are read top-down. Which means we'll try the Nushell heuristic first and if it doesn't match, we move onto the next regex for that extension. If there isn't one, or there isn't a match, we move onto the classifier. The classifier should be considered the last resort as it's trained on the samples and as such may not be accurate.

By adding - language: Nu to the end of the heuristics, you tell Linguist that if the .nu file it is analysing doesn't match the Nushell regex, it will be identified as Nu and Linguist will then not try analysing the file with the classifier.

The assert_heuristics test you've added needs to be updated to test and confirm this behaviour for the Nu samples we already have. You can see how this is done with other tests in this file.

[hustcer]

@lildude Thanks for the detailed explanation, I have just updated the PR, Please check it again

[hustcer]

Should fix #6214

[hustcer]

@lildude Can this PR be Approved?

[lildude]

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.