-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Noir #6432
base: master
Are you sure you want to change the base?
Add Noir #6432
Conversation
I'm not sure what is going on with Github search, but there are fewer files found today than yesterday. There should be more--I pushed a public repo and I know for a fact at least 3 other people did as well. |
Co-authored-by: Colin Seymour <colin@github.com>
@lildude Do you need anything else from me on this? I am wondering how to best track popularity. When I first drafted this search query, there were 376 files. Now its only showing 358. I know more people have been pushing public repos, so it doesn't seem to be picking up on them for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might have put the samples/Noir/roff.nr
sample in the wrong directory or accidentally added it as it looks more like Roff than Noir to my naïve eye.
The same applies for the samples/Noir/roff1.nr
sample which is also massive and waaay bigger than we need. ProTip: if the diff suppresses the content, the file is too big.
There's only search, which is expected to fluctuate as people add and remove repos and files. This is only really noticeable as there are so few files. When things reach close to our requirements, a deviation of 18 files is trivial and not really an issue. |
Do you need examples of Roff, since it has the same extension as Noir? Should I add them to |
Just curious, how do you assess when things reach close to your requirements, since the search doesn't return the number of repos? |
Noir and Roff are very different so the classifier shouldn't have problems distinguishing between the two. That said, there's no harm adding one (the smaller) to the Roff samples directory. As we'll then have two for each language, the "Classifier cross-validation (pull_request)" test will then start to test the classifier for the
See #5756 (this is referenced in the docs too). I'm slowly reassessing this now the new search is open for all and we can get better results. When I've come up with a good reliable strategy, I'll update the docs and close that issue. |
Thanks for your help with this! Let me know if I need to make any more updates. |
This can be changed when the grammar is added
done! |
Our query is hitting 2k! Can we merge this now? |
The submodule could probably do with a bump btw @critesjosh. We've made some changes to the highlighting recently. |
@lildude how are we doing with this integration? There are more and more people exploring zero-knowledge proofs so it would be really cool to have support 😊 |
Still got failing tests. Run this cmd to fix. I'll re-evaluate popularity when I come to make the next release which will in the next two weeks, assuming the failures have been addressed by then. |
Thanks! Just ran the command and pushed changes |
Things don't look popular enough once we exclude the |
Hitting 1.8k again, when is a new release planned @lildude ? |
Same as usual... approx 3-4 months after the last one. |
Requested changes applied. Pending popularity now.
2.1k 🚀 @lildude curious if that's sufficient popularity? |
@lildude I vouch this PR as a user :) |
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Description
Adding the Noir programming language.
Checklist:
#2f1f49