Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of tree-sitter grammars #6460

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

lildude
Copy link
Member

@lildude lildude commented Jun 22, 2023

Description

The syntax highlighting engine team has added a few more tree-sitter grammars to the engine and this PR updates our list to match:

  • C
  • C#
  • Nix
  • Regular Expressions

Checklist:

Removed as it doesn't apply.

@lildude lildude requested a review from a team as a code owner June 22, 2023 11:08
@lildude lildude merged commit e855ef2 into master Jun 22, 2023
@lildude lildude deleted the lildude/tree-sitter-grammars branch June 22, 2023 13:49
tuxtvvixx

This comment was marked as spam.

@Alhadis
Copy link
Collaborator

Alhadis commented Jun 24, 2023

  • Regular Expressions

Ugh, seriously? The tree-sitter grammar appears to be specific to ECMAScript regular expressions, whereas language-regexp takes pains to support as many different regex flavours as possible. Argh. 😞

@sambacha
Copy link

sambacha commented Jul 9, 2023

  • Regular Expressions

Ugh, seriously? The tree-sitter grammar appears to be specific to ECMAScript regular expressions, whereas language-regexp takes pains to support as many different regex flavours as possible. Argh. 😞

Is there any comparison testing done of older grammars and the newer tree sitter based ones?

@lildude
Copy link
Member Author

lildude commented Jul 12, 2023

Is there any comparison testing done of older grammars and the newer tree sitter based ones?

A quick eyeball of the appearance is done. If it looks about right, and performs well, the grammar is used. If it doesn't, as was the case when we tried to use the Svelte tree-sitter grammar as commented here, we don't.

Any discrepancies over "colour choice" for various tokens are down to grammar design decisions and would need to be taken up with the upstream grammar maintainers.

@sambacha
Copy link

Is there any comparison testing done of older grammars and the newer tree sitter based ones?

A quick eyeball of the appearance is done. If it looks about right, and performs well, the grammar is used. If it doesn't, as was the case when we tried to use the Svelte tree-sitter grammar as commented here, we don't.

Any discrepancies over "colour choice" for various tokens are down to grammar design decisions and would need to be taken up with the upstream grammar maintainers.

Thanks for answering my question, cheers!

@salma0303

This comment was marked as spam.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants