-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create devcontainer configuration #6479
Conversation
This is to install additional dependencies that don't come with base image.
This is looking good. I'll see if I can find time to play in the next week or two. One thing we'll definitely want to do as part of this PR is update the CONTRIBUTING.md file to detail how peeps can use this for Codespaces and local docker dev.
Latest released version to align more closely with GitHub production.
TBC. I'll need to check my original branch as I know I added some.
I'm undecided on this ATM. Yes, because it's a better experience and doesn't result in the warning message. No, because it does work and is only an issue during the initial cloning of the grammars, it shouldn't be an issue with prebuilds (might need a few tweaks), and because it costs users more. I'll think about it. |
Oh, just found out that some tests will error out in the codespace because some refs used for testing don't exist. Since it should work for both the main repo and forks, and forks by default only copy the main branch, perhaps this could be part of the post create command: git remote add linguist https://github.com/github-linguist/linguist
git fetch linguist ... Or we could get more advanced and detect if |
These references are necessary for tests to work properly.
Most peeps will be editing the YAML files so lets ensure a better experience
This will allow the bootstrapping to be cached in the prebuild and save users a lot of time
I've had a chance to play with this today and it's looking good. I've made a few tweaks:
Can you please also test this and know what you think @spenserblack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick. Don't consider it a blocker or anything.
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Just tested quickly by letting a prebuild run, opening a codespace, and running Unfortunately, I'm at >90% of my codespace storage quota, so after that quick test I promptly deleted my codespace and the prebuilds 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @spenserblack 🙇
Description
See #6473
Currently, prebuilds are available from my fork, built from the
devcontainer
branch. Hopefully none of the reviewers of this PR are in East Asia, because that's the one region I didn't enable in order to save on storage usage 🙃This will probably need some further changes. Some things I can think of off the top of my head are
script/bootstrap
is a post-create command, and it can apparently hit 100% CPU usage with a 2-core codespace. Should the min requirements be specified as 4-core?Checklist:
(Don't think any of the checkboxes apply, sorry if one does)