-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Magik language support #6488
base: master
Are you sure you want to change the base?
Conversation
vendor/grammars/magik-vscode: | ||
- source.magik | ||
- text.definition | ||
- text.message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These text
ones seem erroneous - only source.magik
is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback! I agree with this statement, however was unsure if I should modify grammars.yml as this was automatically generated by the scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not manually modify this file. It's maintained by a script and should remain that way. The script will always find all grammars in the repo and add them to this file so there's nothing wrong with this.
samples/Magik/vscode_dev.magik
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just from feedback I've gotten in my own PRs, I'm pretty sure that a 3000+ line sample is too large 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip! I will remove it.
Is this PR still alive? I am working on a tree-sitter with a colleague of mine for Magik, which will improve the parsing of Magik even more. It would be great if Magik will be supported by linguist. It is already added to Rouge 5 years ago, which is used by GitLab. |
I believe it's still "Pending Popularity". @lildude apologies if this is documented somewhere, is there specific criteria we should try to meet to satisfy the popularity requirement? |
Yes. See the CONTRIBUTING.md file and the issue it references. |
Thank you, could you re-assess this PR since it has almost 1000 code search results. |
It'll be re-assessed when I'm close to making a new release, but even without looking, this doesn't meet the doc'd requirements detailed in the issue referenced in the CONTRIBUTING.md file. |
I would like to help to update this PR to meet the doc'd requirements. Are we talking about the same issue? #5756. I hope we can reach consensus and maybe make an exception for this language? |
I'm referring to #5756 We've always relied upon public repo usage (we can't measure private repo usage) and allowing exceptions "just this once" opens us up to a similar time-consuming fight each and every time someone develops "the next greatest thing, promise on my hamster's life" or adds support for a lesser used langauge. Sticking with a consistent policy ensures fair treatment of all and everyone knows what the expectations are. |
What is the "normal" search query for number of files per extension? If we include forks, we already have 1K files. |
Magik has been added to |
Add a new programming language to Linguist, called Magik.
Description
Magik is a hybrid procedural and object-oriented language implemented as part of Smallworld Geographical Information System (GIS) and is provided by General Electric. Magik shares similarities with Smalltalk in terms of architecture and language features, providing readable syntax and an interactive development environment.
Checklist:
#005E60
I have updated the heuristics to distinguish my language from others using the same extension.No other language in this repository uses the extension.magik
, so I did not add a heuristic