-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Glimmer language #6556
Add Glimmer language #6556
Conversation
script/add-grammar https://github.com/lifeart/vsc-ember-syntax Note: I removed `text.html.handlebars` from the `vsc-ember-syntax` in grammars.yml to (hopefully) avoid conficting with the existing Handlebars syntax which is also provided by `vsc-ember-syntax`.
…ber Image and Glimmer languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a quick scan but usage isn't high enough for either extension yet. I'll review this as I make each release.
The extension usage is counted individually? Even though they're basically the same? That'd be like treating js and ts separately? |
Yup. This is documented. Once a language has an extension that meets the usage requirements, an override can be used for the others until such time as they’re popular enough for inclusion.
We do as Typescript is technically not JavaScript. They’re also considered two separate languages as they use two different syntax highlighting grammars. Your grammar repo does too 😉 |
ok, thanks far clarifying. ❤️ We'll keep growing the adoption in the mean time tho! |
@lildude To clarify, it's 200 unique repos or 2,000 total files, right? How many unique repos are there so far? |
I think this will probably be due to rounding of the numbers, but I'm only guessing; I'm not involved with the Search side of things. As an aside, we really don't need these weekly updates. The PR won't be merged any quicker as I only merge feature additions when I make a new release which aligns approximately with the GitHub Enterprise Server releases. I also assess all pending popularity PRs at the same time. There are also test failures that need addressing. |
fair enough! I was doing it more for the ember community, as they often ask -- but I suppose links to the queries is probably sufficient!
@gilest can you take a look at those? |
Because otherwise it fails the TestGrammars#test_readme_file_is_in_sync test. Not sure why this URL is considered not in sync. Maybe because of `ace_mode: javascript`?
Given that
I'm considering opening a new PR targeting Glimmer JS only |
Closed in favour of #6578 Will stand up a separate PR for the TS language later on |
Description
Adds support for Glimmer.js which will be the component authoring format of the next Edition of Ember.js.
Checklist:
#F5835F